In change I44865af3d5eb2d37eb648ac7227277e86c8fbc54 we add support to change rabbitmq password on update. This breaks when using containers in a number of scenarios: - FFU because at this stage rabbitmq can be down on the node and the call to rabbitmq_user will trigger a rabbitmqctl list_user call which will eventually time out. - Controller replacement procedure because on the newly replaced controller rabbitmq will not be up yet and the rabbitmq_user call will timeout just like during FFU. - Upgrades from Pike to Queens upgrades we seem to be hitting the same issue as FFU The exact error that we will get on the non bootstrap nodes is the following: =ERROR REPORT==== 3-Mar-2018::05:37:39 ===** Connection attempt from disallowed node 'rabbitmq-cli-67@controller-1' ** The reason for this is that on non bootstrap node we do not enforce the Exec['rabbitmq-ready'] -> Rabbitmq_user<||> collector, because we do not want to enforce it there (think controller replacement) Let's make sure we enforce the Rabbitmq_user class only on bootstrap nodes, since in HA deployments the users get replicated by the cluster anyway. Co-Authored-By: Damien Ciabrini <dciabrin@redhat.com> Co-Authored-By: John Eckersberg <jeckersb@redhat.com> Closes-Bug: #1753949 Change-Id: I483fe61f09fa2c3034d2b3d8ffa1ca53feefe6af
191 lines
7.1 KiB
Puppet
191 lines
7.1 KiB
Puppet
# Copyright 2016 Red Hat, Inc.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
#
|
|
# == Class: tripleo::profile::base::rabbitmq
|
|
#
|
|
# RabbitMQ profile for tripleo
|
|
#
|
|
# === Parameters
|
|
#
|
|
# [*certificate_specs*]
|
|
# (Optional) The specifications to give to certmonger for the certificate
|
|
# it will create. Note that the certificate nickname must be 'mysql' in
|
|
# the case of this service.
|
|
# Example with hiera:
|
|
# tripleo::profile::base::database::mysql::certificate_specs:
|
|
# hostname: <overcloud controller fqdn>
|
|
# service_certificate: <service certificate path>
|
|
# service_key: <service key path>
|
|
# principal: "mysql/<overcloud controller fqdn>"
|
|
# Defaults to {}.
|
|
#
|
|
# [*config_variables*]
|
|
# (Optional) RabbitMQ environment.
|
|
# Defaults to hiera('rabbitmq_config_variables').
|
|
#
|
|
# [*enable_internal_tls*]
|
|
# (Optional) Whether TLS in the internal network is enabled or not.
|
|
# Defaults to undef
|
|
#
|
|
# [*environment*]
|
|
# (Optional) RabbitMQ environment.
|
|
# Defaults to hiera('rabbitmq_environment').
|
|
#
|
|
# [*inet_dist_interface*]
|
|
# (Optional) Address to bind the inter-cluster interface
|
|
# to. It is the inet_dist_use_interface option in the kernel variables
|
|
# Defaults to hiera('rabbitmq::interface', undef).
|
|
#
|
|
# [*ipv6*]
|
|
# (Optional) Whether to deploy RabbitMQ on IPv6 network.
|
|
# Defaults to str2bool(hiera('rabbit_ipv6', false)).
|
|
#
|
|
# [*kernel_variables*]
|
|
# (Optional) RabbitMQ environment.
|
|
# Defaults to hiera('rabbitmq_environment').
|
|
#
|
|
# [*nodes*]
|
|
# (Optional) Array of host(s) for RabbitMQ nodes.
|
|
# Defaults to hiera('rabbitmq_node_names', []).
|
|
#
|
|
# [*rabbitmq_pass*]
|
|
# (Optional) RabbitMQ Default Password.
|
|
# Defaults to hiera('rabbitmq::default_pass')
|
|
#
|
|
# [*rabbitmq_user*]
|
|
# (Optional) RabbitMQ Default User.
|
|
# Defaults to hiera('rabbitmq::default_user')
|
|
#
|
|
# [*stack_action*]
|
|
# (Optional) Action of the stack deployment.
|
|
# Defaults to hiera('stack_action')
|
|
#
|
|
# [*step*]
|
|
# (Optional) The current step in deployment. See tripleo-heat-templates
|
|
# for more details.
|
|
# Defaults to hiera('step')
|
|
#
|
|
# [*bootstrap_node*]
|
|
# (Optional) The hostname of the node responsible for bootstrapping tasks
|
|
# Defaults to hiera('rabbitmq_short_bootstrap_node_name')
|
|
#
|
|
class tripleo::profile::base::rabbitmq (
|
|
$certificate_specs = {},
|
|
$config_variables = hiera('rabbitmq_config_variables'),
|
|
$enable_internal_tls = undef, # TODO(jaosorior): pass this via t-h-t
|
|
$environment = hiera('rabbitmq_environment'),
|
|
$inet_dist_interface = hiera('rabbitmq::interface', undef),
|
|
$ipv6 = str2bool(hiera('rabbit_ipv6', false)),
|
|
$kernel_variables = hiera('rabbitmq_kernel_variables'),
|
|
$nodes = hiera('rabbitmq_node_names', []),
|
|
$rabbitmq_pass = hiera('rabbitmq::default_pass'),
|
|
$rabbitmq_user = hiera('rabbitmq::default_user'),
|
|
$stack_action = hiera('stack_action'),
|
|
$step = Integer(hiera('step')),
|
|
$bootstrap_node = hiera('rabbitmq_short_bootstrap_node_name'),
|
|
) {
|
|
if $enable_internal_tls {
|
|
$tls_certfile = $certificate_specs['service_certificate']
|
|
$tls_keyfile = $certificate_specs['service_key']
|
|
$cert_option = "-ssl_dist_opt server_certfile ${tls_certfile}"
|
|
$key_option = "-ssl_dist_opt server_keyfile ${tls_keyfile}"
|
|
$secure_renegotiate = '-ssl_dist_opt server_secure_renegotiate true -ssl_dist_opt client_secure_renegotiate true'
|
|
|
|
$rabbitmq_additional_erl_args = "\"${cert_option} ${key_option} ${secure_renegotiate}\""
|
|
$environment_real = merge($environment, {
|
|
'RABBITMQ_SERVER_ADDITIONAL_ERL_ARGS' => $rabbitmq_additional_erl_args,
|
|
'RABBITMQ_CTL_ERL_ARGS' => $rabbitmq_additional_erl_args
|
|
})
|
|
} else {
|
|
$tls_certfile = undef
|
|
$tls_keyfile = undef
|
|
$environment_real = $environment
|
|
}
|
|
|
|
if $inet_dist_interface {
|
|
$real_kernel_variables = merge(
|
|
$kernel_variables,
|
|
{ 'inet_dist_use_interface' => ip_to_erl_format($inet_dist_interface) }
|
|
)
|
|
} else {
|
|
$real_kernel_variables = $kernel_variables
|
|
}
|
|
|
|
$manage_service = hiera('rabbitmq::service_manage', true)
|
|
if $step >= 1 {
|
|
# Specific configuration for multi-nodes or when running with Pacemaker.
|
|
if count($nodes) > 1 or ! $manage_service {
|
|
class { '::rabbitmq':
|
|
config_cluster => $manage_service,
|
|
cluster_nodes => $nodes,
|
|
config_kernel_variables => $real_kernel_variables,
|
|
config_variables => $config_variables,
|
|
environment_variables => $environment_real,
|
|
# TLS options
|
|
ssl_cert => $tls_certfile,
|
|
ssl_key => $tls_keyfile,
|
|
ipv6 => $ipv6,
|
|
}
|
|
# when running multi-nodes without Pacemaker
|
|
if $manage_service {
|
|
rabbitmq_policy { 'ha-all@/':
|
|
pattern => '^(?!amq\.).*',
|
|
definition => {
|
|
'ha-mode' => 'all',
|
|
},
|
|
}
|
|
}
|
|
} else {
|
|
# Standard configuration
|
|
class { '::rabbitmq':
|
|
config_kernel_variables => $kernel_variables,
|
|
config_variables => $config_variables,
|
|
environment_variables => $environment,
|
|
# TLS options
|
|
ssl_cert => $tls_certfile,
|
|
ssl_key => $tls_keyfile,
|
|
ipv6 => $ipv6,
|
|
}
|
|
}
|
|
}
|
|
|
|
if $::hostname == downcase($bootstrap_node) {
|
|
$rabbitmq_bootstrapnode = true
|
|
} else {
|
|
$rabbitmq_bootstrapnode = false
|
|
}
|
|
|
|
if $rabbitmq_bootstrapnode and $step >= 2 {
|
|
# In case of HA, starting of rabbitmq-server is managed by pacemaker, because of which, a dependency
|
|
# to Service['rabbitmq-server'] will not work. Sticking with UPDATE action.
|
|
# When need to enforce the rabbitmq user inside a bootstrap node check for two reasons:
|
|
# a) on HA the users get replicated by the cluster anyway
|
|
# b) in the pacemaker profiles for rabbitmq we have an Exec['rabbitmq-ready'] -> Rabbitmq_User<||> collector
|
|
# which is applied only on the bootstrap node (because enforcing the readiness on all nodes can be problematic
|
|
# in situations like controller replacement)
|
|
if $stack_action == 'UPDATE' {
|
|
# Required for changing password on update scenario. Password will be changed only when
|
|
# called explicity, if the rabbitmq service is already running.
|
|
rabbitmq_user { $rabbitmq_user :
|
|
password => $rabbitmq_pass,
|
|
admin => true,
|
|
}
|
|
}
|
|
if hiera('veritas_hyperscale_controller_enabled', false) {
|
|
include ::veritas_hyperscale::hs_rabbitmq
|
|
}
|
|
}
|
|
|
|
}
|