c765a81ea4
libvirt 6.8.0 introduces virt-ssh-helper which prepends the libvirt ssh command with a "which virt-ssh-helper". libvirt used to first check for `nc` (netcat). But these two libvirt commits[1][2] have now changed it to first look for `virt-ssh-helper`, if it not available, then fall back to `nc`. The nova-migration-wrapper doesn't accept this command and denies the connection. Until nova-migration-wrapper is changed to allow the usage of virt-ssh-helper, this change force to use "netcat" (`nc`) by appending to the migration URI: "&proxy=netcat" [1] https://libvirt.org/git/?p=libvirt.git;a=commit;h=f8ec7c842d (rpc: use new virt-ssh-helper binary for remote tunnelling, 2020-07-08) [2] https://libvirt.org/git/?p=libvirt.git;a=commit;h=7d959c302d (rpc: Fix virt-ssh-helper detection, 2020-10-27) Closes-Bug: 1918250 Related: https://bugzilla.redhat.com/show_bug.cgi?id=1926602 Change-Id: I3db9cd42aa63379ed6332ee77f67d1dfe4be8504 Co-Authored-By: David Vallee Delisle <dvd@redhat.com> (cherry picked from commit 04a97f92e4d944ce51492011584e2ec1126042a1) (cherry picked from commit bf5a4a9849d7cb067d36ca57fd8538faed016715) (cherry picked from commit 960dbfe986b06a9b390b4adac1fca57c8badb3e7)