a0cfe0afdd
Currently there is a race with the high-availability of ovn when resetting a controller. Namely, the VIP that OVN uses (namely the internal_api VIP by default) only has a colocation constraint with the master role of the ovn-dbs resource. This leaves the following race open: 1) We reboot ctrl-0 hosting the master role of ovn-dbs 2) OVN becomes master on ctrl-1 from pacemaker's POV (but the promotion operation running in the background is not completed) 3) OVN VIP moves to ctrl-1 even though it is still in slave mode (there is only a colocation constraint between vip and master role for ovn) 4) OVN controllers on the overcloud connect to the VIP but it is in read-only mode because it was a slave 5) OVN controllers that connected at 4) stay in read-only forever until they get restarted manually. With the addition of this constraint we force the VIP move only after the master role has been promoted. This makes it much more unlikely for a client to connect to the VIP and get a read-only db in the background. With only this patch applied I did not manage to reproduce the issue (even after 7 reboots of controllers). Note that there is still a small race window possible because the current OVN resource agent has a bug: it promotes a resource to master after issuing the promotion command to the DB but without waiting for this promotion to complete. A patch for OVN-ra will also be submitted but from initial testing this change seems to be largely sufficient. Also note that this change introduces a small less desirable side-effect: A failover of the internal VIP will now take a bit longer because it will happen only after ovn-dbs gets promoted to master. We plan to take care of this fully by decoupling the OVN VIP from the internal_api one. This change addresses the immediate issue related to ovn_controllers being stuck in read-only due to premature promotion. (OVN upstream is discussing how to make connections to read-only VIP trigger a reconnection eventually) Closes-Bug: #1835830 Change-Id: I3fa07e28c4e37197890664d12a265f1673c780f2 (cherry picked from commit |
||
|---|---|---|
| files | ||
| lib | ||
| manifests | ||
| releasenotes | ||
| spec | ||
| templates | ||
| zuul.d | ||
| .gitignore | ||
| .gitreview | ||
| .sync.yml | ||
| Gemfile | ||
| LICENSE | ||
| Puppetfile_extras | ||
| README.md | ||
| Rakefile | ||
| bindep.txt | ||
| metadata.json | ||
| setup.cfg | ||
| setup.py | ||
| test-requirements.txt | ||
| tox.ini | ||
README.md
Team and repository tags
puppet-tripleo
Lightweight composition layer for Puppet TripleO.
Contributing
- Free software: Apache License (2.0)
- Source: http://git.openstack.org/cgit/openstack/puppet-tripleo
- Bugs: http://bugs.launchpad.net/tripleo (tag: puppet)
- Documentation: