From 1afa1afac188cf759190f23fd20469bc424860ee Mon Sep 17 00:00:00 2001
From: ZhongShengping <chdzsp@163.com>
Date: Thu, 20 Aug 2020 10:41:27 +0800
Subject: [PATCH] Add service_token_roles for keystone authtoken config

Add the ability to configure service_token_roles.

Change-Id: Ia19efd5737c57ccf0f7922c037cce47adf9a2fd6
Closes-Bug: #1892284
---
 manifests/keystone/authtoken.pp                      | 12 ++++++++++++
 ...-service_token_roles-option-9dca2ded7ff9094f.yaml |  4 ++++
 spec/classes/trove_keystone_authtoken_spec.rb        |  3 +++
 3 files changed, 19 insertions(+)
 create mode 100644 releasenotes/notes/add-service_token_roles-option-9dca2ded7ff9094f.yaml

diff --git a/manifests/keystone/authtoken.pp b/manifests/keystone/authtoken.pp
index e83bbee3..e2fcbd35 100644
--- a/manifests/keystone/authtoken.pp
+++ b/manifests/keystone/authtoken.pp
@@ -166,6 +166,16 @@
 #   (in seconds). Set to -1 to disable caching completely. Integer value
 #   Defaults to $::os_service_default.
 #
+# [*service_token_roles*]
+#   (Optional) A choice of roles that must be present in a service token.
+#   Service tokens are allowed to request that an expired token
+#   can be used and so this check should tightly control that
+#   only actual services should be sending this token. Roles
+#   here are applied as an ANY check so any role in this list
+#   must be present. For backwards compatibility reasons this
+#   currently only affects the allow_expired check. (list value)
+#   Defaults to $::os_service_default.
+#
 # [*service_token_roles_required*]
 #   (optional) backwards compatibility to ensure that the service tokens are
 #   compared against a list of possible roles for validity
@@ -210,6 +220,7 @@ class trove::keystone::authtoken(
   $manage_memcache_package        = false,
   $region_name                    = $::os_service_default,
   $token_cache_time               = $::os_service_default,
+  $service_token_roles            = $::os_service_default,
   $service_token_roles_required   = $::os_service_default,
   $interface                      = $::os_service_default,
 ) {
@@ -253,6 +264,7 @@ class trove::keystone::authtoken(
     manage_memcache_package        => $manage_memcache_package,
     region_name                    => $region_name,
     token_cache_time               => $token_cache_time,
+    service_token_roles            => $service_token_roles,
     service_token_roles_required   => $service_token_roles_required,
     interface                      => $interface,
   }
diff --git a/releasenotes/notes/add-service_token_roles-option-9dca2ded7ff9094f.yaml b/releasenotes/notes/add-service_token_roles-option-9dca2ded7ff9094f.yaml
new file mode 100644
index 00000000..ad0f1614
--- /dev/null
+++ b/releasenotes/notes/add-service_token_roles-option-9dca2ded7ff9094f.yaml
@@ -0,0 +1,4 @@
+---
+features:
+  - |
+    Add support to configure service_token_roles in authtoken middleware.
diff --git a/spec/classes/trove_keystone_authtoken_spec.rb b/spec/classes/trove_keystone_authtoken_spec.rb
index cb70fca7..e791095f 100644
--- a/spec/classes/trove_keystone_authtoken_spec.rb
+++ b/spec/classes/trove_keystone_authtoken_spec.rb
@@ -42,6 +42,7 @@ describe 'trove::keystone::authtoken' do
         is_expected.to contain_trove_config('keystone_authtoken/memcached_servers').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_trove_config('keystone_authtoken/region_name').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_trove_config('keystone_authtoken/token_cache_time').with_value('<SERVICE DEFAULT>')
+        is_expected.to contain_trove_config('keystone_authtoken/service_token_roles').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_trove_config('keystone_authtoken/service_token_roles_required').with_value('<SERVICE DEFAULT>')
         is_expected.to contain_trove_config('keystone_authtoken/interface').with_value('<SERVICE DEFAULT>')
       end
@@ -82,6 +83,7 @@ describe 'trove::keystone::authtoken' do
           :manage_memcache_package              => true,
           :region_name                          => 'region2',
           :token_cache_time                     => '301',
+          :service_token_roles                  => ['service'],
           :service_token_roles_required         => false,
           :interface                            => 'internal',
         })
@@ -119,6 +121,7 @@ describe 'trove::keystone::authtoken' do
         is_expected.to contain_trove_config('keystone_authtoken/memcached_servers').with_value('memcached01:11211,memcached02:11211')
         is_expected.to contain_trove_config('keystone_authtoken/region_name').with_value(params[:region_name])
         is_expected.to contain_trove_config('keystone_authtoken/token_cache_time').with_value(params[:token_cache_time])
+        is_expected.to contain_trove_config('keystone_authtoken/service_token_roles').with_value(params[:service_token_roles])
         is_expected.to contain_trove_config('keystone_authtoken/service_token_roles_required').with_value(params[:service_token_roles_required])
         is_expected.to contain_trove_config('keystone_authtoken/interface').with_value(params[:interface])
       end