openstack/puppet-trove
Code Issues Proposed changes

Add support for [cache] backend_expiration_time

Browse Source 
Depends-on: https://review.opendev.org/933978
Change-Id: I4d4f8c5476053d12117753365a4559d9de5e361d
This commit is contained in:
Takashi Kajinami 2024-11-03 09:23:57 +09:00
parent e74622e905
commit 373ce3188d
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/cache.pp
View File

@ -18,6 +18,11 @@
# (integer value)
# Defaults to $facts['os_service_default']
#
# [*backend_expiration_time*]
# (Optional) Expiration time in cache backend to purge expired records
# automatically.
# Defaults to $facts['os_service_default']
#
# [*backend*]
# (Optional) Dogpile.cache backend module. It is recommended that
# Memcache with pooling (oslo_cache.memcache_pool) or Redis
@ -215,6 +220,7 @@
class trove::cache (
$config_prefix = $facts['os_service_default'],
$expiration_time = $facts['os_service_default'],
$backend_expiration_time = $facts['os_service_default'],
$backend = $facts['os_service_default'],
$backend_argument = $facts['os_service_default'],
$proxies = $facts['os_service_default'],
@ -259,6 +265,7 @@ class trove::cache (
oslo::cache { 'trove_config':
config_prefix => $config_prefix,
expiration_time => $expiration_time,
backend_expiration_time => $backend_expiration_time,
backend => $backend,
backend_argument => $backend_argument,
proxies => $proxies,

4
releasenotes/notes/cache-backend-expiration-time-ff2e121362581278.yaml Normal file
View File

@ -0,0 +1,4 @@
---
features:
- |
The new ``trove::cache::backend_expiration_time`` parameter has been added.

3
spec/classes/trove_cache_spec.rb
View File

@ -13,6 +13,7 @@ describe 'trove::cache' do
is_expected.to contain_oslo__cache('trove_config').with(
:config_prefix => '<SERVICE DEFAULT>',
:expiration_time => '<SERVICE DEFAULT>',
:backend_expiration_time => '<SERVICE DEFAULT>',
:backend => '<SERVICE DEFAULT>',
:backend_argument => '<SERVICE DEFAULT>',
:proxies => '<SERVICE DEFAULT>',
@ -59,6 +60,7 @@ describe 'trove::cache' do
{
:config_prefix => 'prefix',
:expiration_time => 3600,
:backend_expiration_time => 7200,
:backend => 'oslo_cache.memcache_pool',
:proxies => ['proxy01:8888', 'proxy02:8888'],
:enabled => true,
@ -98,6 +100,7 @@ describe 'trove::cache' do
is_expected.to contain_oslo__cache('trove_config').with(
:config_prefix => 'prefix',
:expiration_time => 3600,
:backend_expiration_time => 7200,
:backend => 'oslo_cache.memcache_pool',
:backend_argument => '<SERVICE DEFAULT>',
:proxies => ['proxy01:8888', 'proxy02:8888'],