From 6dc198fe4e1547a773c0ca45f8a9b95396df7bfe Mon Sep 17 00:00:00 2001
From: ZhongShengping <chdzsp@163.com>
Date: Mon, 15 Jan 2018 16:26:34 +0800
Subject: [PATCH] Add use_journal option for logging configuration

This enables oslo.log to pass logging records to journald.

Change-Id: I36d78d2642ee7b2dbaa1256e69dbd963696dd8e3
---
 manifests/logging.pp                                        | 6 ++++++
 ...add-use_journal-option-for-logging-94d344838c254a75.yaml | 5 +++++
 spec/classes/trove_logging_spec.rb                          | 3 +++
 3 files changed, 14 insertions(+)
 create mode 100644 releasenotes/notes/add-use_journal-option-for-logging-94d344838c254a75.yaml

diff --git a/manifests/logging.pp b/manifests/logging.pp
index 0c674fed..c407b34e 100644
--- a/manifests/logging.pp
+++ b/manifests/logging.pp
@@ -16,6 +16,10 @@
 #    (Optional) Use json for logging.
 #    Defaults to $::os_service_default
 #
+#  [*use_journal*]
+#    (Optional) Use journal for logging.
+#    Defaults to $::os_service_default
+#
 #  [*use_stderr*]
 #    (optional) Use stderr for logging
 #    Defaults to $::os_service_default
@@ -97,6 +101,7 @@
 class trove::logging(
   $use_syslog                    = $::os_service_default,
   $use_json                      = $::os_service_default,
+  $use_journal                   = $::os_service_default,
   $use_stderr                    = $::os_service_default,
   $log_facility                  = $::os_service_default,
   $log_dir                       = '/var/log/trove',
@@ -139,6 +144,7 @@ class trove::logging(
     use_stderr                    => $use_stderr_real,
     use_syslog                    => $use_syslog_real,
     use_json                      => $use_json,
+    use_journal                   => $use_journal,
     log_dir                       => $log_dir_real,
     log_file                      => $log_file_real,
     syslog_log_facility           => $log_facility_real,
diff --git a/releasenotes/notes/add-use_journal-option-for-logging-94d344838c254a75.yaml b/releasenotes/notes/add-use_journal-option-for-logging-94d344838c254a75.yaml
new file mode 100644
index 00000000..12b190e7
--- /dev/null
+++ b/releasenotes/notes/add-use_journal-option-for-logging-94d344838c254a75.yaml
@@ -0,0 +1,5 @@
+---
+features:
+  - |
+    Adds the use_journal option for configuring oslo.log. This will enable
+    passing the logs to journald.
diff --git a/spec/classes/trove_logging_spec.rb b/spec/classes/trove_logging_spec.rb
index 30c498f0..adfa3840 100644
--- a/spec/classes/trove_logging_spec.rb
+++ b/spec/classes/trove_logging_spec.rb
@@ -25,6 +25,7 @@ describe 'trove::logging' do
      :log_date_format => '%Y-%m-%d %H:%M:%S',
      :use_syslog => true,
      :use_json => true,
+     :use_journal => true,
      :use_stderr => false,
      :log_facility => 'LOG_FOO',
      :log_dir => '/var/log',
@@ -60,6 +61,7 @@ describe 'trove::logging' do
       is_expected.to contain_oslo__log('trove_config').with(
         :use_syslog          => '<SERVICE DEFAULT>',
         :use_json            => '<SERVICE DEFAULT>',
+        :use_journal         => '<SERVICE DEFAULT>',
         :use_stderr          => '<SERVICE DEFAULT>',
         :syslog_log_facility => '<SERVICE DEFAULT>',
         :log_dir             => '/var/log/trove',
@@ -74,6 +76,7 @@ describe 'trove::logging' do
       is_expected.to contain_oslo__log('trove_config').with(
         :use_syslog          => true,
         :use_json            => true,
+        :use_journal         => true,
         :use_stderr          => false,
         :syslog_log_facility => 'LOG_FOO',
         :log_dir             => '/var/log',