openstack/puppet-trove
Code Issues Proposed changes

Deprecate ineffective rabbit_notification_topic

Browse Source 
This parameter has never been used since the initial release (6.0.0).

Change-Id: I645475b504940a5caffd5a69ad95b83cab4033e2
This commit is contained in:
Takashi Kajinami 2024-09-30 21:36:23 +09:00
parent 32e7d18998
commit 74b6a63384
2 changed files with 17 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
manifests/init.pp
View File

@ -47,10 +47,6 @@
# (optional) Connect over SSL for RabbitMQ
# Defaults to $facts['os_service_default']
#
# [*rabbit_notification_topic*]
# (optional) Notification topic.
# Defaults to $facts['os_service_default']
#
# [*kombu_ssl_ca_certs*]
# (optional) SSL certification authority file (valid only if SSL enabled).
# Defaults to $facts['os_service_default']
@ -240,6 +236,12 @@
# (optional) The state of the package.
# Defaults to 'present'
#
# DEPRECATED PARAMETERS
#
# [*rabbit_notification_topic*]
# (optional) Notification topic.
# Defaults to undef
#
class trove(
$default_transport_url = $facts['os_service_default'],
$notification_transport_url = $facts['os_service_default'],
@ -247,7 +249,6 @@ class trove(
$notification_topics = $facts['os_service_default'],
$rabbit_use_ssl = $facts['os_service_default'],
$rabbit_ha_queues = $facts['os_service_default'],
$rabbit_notification_topic = $facts['os_service_default'],
$rabbit_heartbeat_timeout_threshold = $facts['os_service_default'],
$rabbit_heartbeat_rate = $facts['os_service_default'],
$rabbit_heartbeat_in_pthread = $facts['os_service_default'],
@ -289,12 +290,18 @@ class trove(
$volume_rootdisk_support = $facts['os_service_default'],
$volume_rootdisk_size = $facts['os_service_default'],
$package_ensure = 'present',
# DEPRECATED PARAMETERS
$rabbit_notification_topic = undef,
) {
include trove::deps
include trove::policy
include trove::params
if $rabbit_notification_topic != undef {
warning('The rabbit_notification_topic parameter is deprecated and has no effect.')
}
package { 'trove':
ensure => $package_ensure,
name => $::trove::params::common_package_name,

5
releasenotes/notes/deprecate-rabbit_notification_topic-50956d3673363355.yaml Normal file
View File

@ -0,0 +1,5 @@
---
deprecations:
- |
The ``trove::rabbit_notification_topic`` parameter has been deperecated,
because it has had no effect.