openstack
/
puppet-trove
Code Issues Proposed changes

Add support for the interface parameter in authtoken middleware 

This patch adds support for [keystone_authtoken] interface parameter,
so that operators can define which endpoint should be used by authtoken
middleware.

Change-Id: If61e708f68f96ce6c485a681d39e17c3cf737d2a
This commit is contained in:
Lewis Denny 2020-07-16 18:06:54 +10:00
parent 05a2bd8514
commit 7585243d3f
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
manifests/keystone/authtoken.pp
View File

@ -172,6 +172,11 @@
# true/false
# Defaults to $::os_service_default.
#
# [*interface*]
# (Optional) Interface to use for the Identity API endpoint. Valid values are
# "public", "internal" or "admin".
# Defaults to $::os_service_default.
#
class trove::keystone::authtoken(
$username = 'trove',
$password = $::os_service_default,
@ -206,6 +211,7 @@ class trove::keystone::authtoken(
$region_name = $::os_service_default,
$token_cache_time = $::os_service_default,
$service_token_roles_required = $::os_service_default,
$interface = $::os_service_default,
) {
include trove::deps
@ -248,5 +254,6 @@ class trove::keystone::authtoken(
region_name => $region_name,
token_cache_time => $token_cache_time,
service_token_roles_required => $service_token_roles_required,
interface => $interface,
}
}

5
releasenotes/notes/keystone-authtoken-interface-a21e29a682e51819.yaml Normal file
View File

@ -0,0 +1,5 @@
---
features:
- |
The new ``trove::keystone::authtoken::interface`` parameter has been added,
which can be used to set the interface parameter in authtoken middleware.

3
spec/classes/trove_keystone_authtoken_spec.rb
View File

@ -43,6 +43,7 @@ describe 'trove::keystone::authtoken' do
is_expected.to contain_trove_config('keystone_authtoken/region_name').with_value('<SERVICE DEFAULT>')
is_expected.to contain_trove_config('keystone_authtoken/token_cache_time').with_value('<SERVICE DEFAULT>')
is_expected.to contain_trove_config('keystone_authtoken/service_token_roles_required').with_value('<SERVICE DEFAULT>')
is_expected.to contain_trove_config('keystone_authtoken/interface').with_value('<SERVICE DEFAULT>')
end
end
@ -82,6 +83,7 @@ describe 'trove::keystone::authtoken' do
:region_name => 'region2',
:token_cache_time => '301',
:service_token_roles_required => false,
:interface => 'internal',
})
end
@ -118,6 +120,7 @@ describe 'trove::keystone::authtoken' do
is_expected.to contain_trove_config('keystone_authtoken/region_name').with_value(params[:region_name])
is_expected.to contain_trove_config('keystone_authtoken/token_cache_time').with_value(params[:token_cache_time])
is_expected.to contain_trove_config('keystone_authtoken/service_token_roles_required').with_value(params[:service_token_roles_required])
is_expected.to contain_trove_config('keystone_authtoken/interface').with_value(params[:interface])
end
it 'installs python memcache package' do