Fix lint issues (doc, metadata, manifests)

Add puppet parameters lint (with puppet-lint-param-docs gem) and fix
missing documentations, this commit also fix manifest lint issues
(due to puppet-lint upgrade) and metadata.json file (SPDX license,
and open dependencies).

Change-Id: Iab6f84f42e8874a10a5fcc886b4a6556fe3e1ed0

Gemfile

@@ -2,10 +2,10 @@ source 'https://rubygems.org'
 
 group :development, :test do
   gem 'puppetlabs_spec_helper', :require => false
-  gem 'puppet-lint', '~> 0.3.2'
+  gem 'metadata-json-lint'
+  gem 'puppet-lint-param-docs'
+
   gem 'rspec-puppet', '~> 1.0.1'
-  gem 'rake', '10.1.1'
-  gem 'rspec', '< 2.99'
   gem 'json'
   gem 'webmock'
 end

manifests/api.pp

@@ -61,12 +61,12 @@
 #   If set to boolean false, it will not log to any file.
 #   Default: /var/log/trove/trove-api.log
 #
-#  [*log_dir*]
-#    (optional) directory to which trove logs are sent.
-#    If set to boolean false, it will not log to any directory.
-#    Defaults to '/var/log/trove'
+# [*log_dir*]
+#   (optional) directory to which trove logs are sent.
+#   If set to boolean false, it will not log to any directory.
+#   Defaults to '/var/log/trove'
 #
-# [* auth_host*]
+# [*auth_host*]
 #   (optional) Host running auth service.
 #   Defaults to '127.0.0.1'.
 #
@@ -74,11 +74,11 @@
 #   (optional) Authentication URL.
 #   Defaults to 'http://localhost:5000/v2.0'.
 #
-# [* auth_port*]
+# [*auth_port*]
 #   (optional) Port to use for auth service on auth_host.
 #   Defaults to '35357'.
 #
-# [* auth_protocol*]
+# [*auth_protocol*]
 #   (optional) Protocol to use for auth.
 #   Defaults to 'http'.
 #

manifests/db/postgresql.pp

@@ -29,8 +29,8 @@ class trove::db::postgresql(
 
 
   postgresql::db { $dbname:
-    user      => $user,
-    password  => $password,
+    user     => $user,
+    password => $password,
   }
 
 }

manifests/init.pp

@@ -125,6 +125,10 @@
 #   (optional) Timeout before idle db connections are reaped.
 #   Defaults to 3600
 #
+# [*nova_compute_url*]
+#   (optional) URL without the tenant segment.
+#   Defaults to false.
+#
 # [*nova_proxy_admin_user*]
 #   (optional) Admin username used to connect to nova.
 #   Defaults to 'admin'
@@ -140,6 +144,14 @@
 #   (optional) Control exchange.
 #   Defaults to 'trove'.
 #
+# [*cinder_url*]
+#   (optional) URL without the tenant segment.
+#   Defaults to false.
+#
+# [*swift_url*]
+#   (optional) Swift URL ending in AUTH_.
+#   Defaults to false.
+#
 # [*use_neutron*]
 #   (optional) Use Neutron
 #   Defaults to true

manifests/taskmanager.pp

@@ -47,9 +47,9 @@
 #   Default: /var/log/trove/trove-taskmanager.log
 #
 # [*log_dir*]
-#    (optional) directory to which trove logs are sent.
-#    If set to boolean false, it will not log to any directory.
-#    Defaults to '/var/log/trove'
+#   (optional) directory to which trove logs are sent.
+#   If set to boolean false, it will not log to any directory.
+#   Defaults to '/var/log/trove'
 #
 # [*use_syslog*]
 #   (optional) Use syslog for logging.
@@ -63,11 +63,14 @@
 #   (optional) Authentication URL.
 #   Defaults to 'http://localhost:5000/v2.0'.
 #
-# [**guestagent_config_file*]
+# [*heat_url*]
+#   (optional) URL without the tenant segment.
+#   Defaults to false
+#
+# [*guestagent_config_file*]
 #   (optional) Trove guest agent configuration file.
 #   Defaults to '/etc/trove/trove-guestmanager.conf'.
 #
-
 class trove::taskmanager(
   $enabled                = true,
   $manage_service         = true,

metadata.json

@@ -3,7 +3,7 @@
   "version": "5.0.0",
   "author": "eNovance and StackForge Contributors",
   "summary": "Puppet module for OpenStack Trove",
-  "license": "Apache License 2.0",
+  "license": "Apache-2.0",
   "source": "git://github.com/stackforge/puppet-trove.git",
   "project_page": "https://launchpad.net/puppet-trove",
   "issues_url": "https://bugs.launchpad.net/puppet-trove",
@@ -34,6 +34,6 @@
     { "name": "puppetlabs/inifile", "version_requirement": ">=1.0.0 <2.0.0" },
     { "name": "stackforge/keystone", "version_requirement": ">=5.0.0 <6.0.0" },
     { "name": "puppetlabs/stdlib", "version_requirement": ">=4.0.0 <5.0.0" },
-    { "name": "stackforge/openstacklib", "version_requirement": ">=5.0.0" }
+    { "name": "stackforge/openstacklib", "version_requirement": ">=5.0.0 <6.0.0" }
   ]
 }