... because the latest lint no longer allows usage of legacy facts and
top scope fact.
This also fixes the wrong wsgi script name introduced by [1] to fix
broken litmus jobs.
[1] d7a1ea5fb7632e58a69f7dead32c28f1a9419a2e
Change-Id: Idb7d655242ccd6f785ea4dfbb94d8ff3ad961b03
... because these options were deprecated during Yoga cycle[1].
[1] a1f85ce1ef33f2d1f8c9bfe89e84d4f8a32248c0
Depends-on: https://review.opendev.org/842828
Change-Id: I6e7402bacd8ca23abda39d9fb3330cface5da288
Currently we validate database_connection in 2 layers, each puppet
modules and puppet-oslo, however this makes it difficult to maintain
validation pattern because we always need to fix both.
This patch removes the validation from each puppet modules so that
we need to maitain only one place, puppet-oslo to update validation
logic.
Change-Id: I6de003300a7efdfca4b38c4b61859891fcc8780b
This changes all the puppet 3 validate_* functions
to use the validate_legacy function.
The validate_legacy function has been available since
about three years but require Puppet >= 4.4.0 and since
there is Puppet 4.10.12 as latest we should assume people
are running a fairly new Puppet 4 version.
This is the first step to then remove all validate function
calls and use proper types for parameter as described in spec [1].
[1] https://review.openstack.org/#/c/568929/
Change-Id: I5d1ebaf9a3b7f6637973ea846d3571c7364feb54
Add pool_timeout option to configure this value for pool_timeout with
SQLAlchemy.
Change-Id: Ib2413bc9da8eb50e310ca1f1e99c5ea0e708d570
Closes-Bug: #1757581
Additonal changes:
* switch database related parameters to $::os_service_default
as they are used in oslo::db
* update unit tests
Change-Id: I2c79261d8000d68521f783b5df9a535ff47ce53d
Move all dependency tracking to an external class which simplifies the
relationships and allows managing Trove without necessarily using
packages.
This change also cleans up how the client is handled to make
it more configurable and match other modules.
Finally the reference to the deprecated and non-functional
keystone::python class is dropped.
Change-Id: I943685fbeb114dead80b7465b8f5c564a0bc9fe0