This change updates the module to use the rspec-puppet-facts as defined
in the puppet-openstack_spec_helper.
Change-Id: I9c1ce41a719a25654f5e8658b65bf629cdc3fa83
Trove is adding policy support, since it's not yet released (landing in
Newton) this code will not auto-include the policy class as other
modules do. That will be done later after all distros support a Trove
version with a policy.json file.
Change-Id: Iae8f8bf341ae17190676c524444600e660420e46
In trove::api, use keystone::resource::authtoken to configure
keystone_authtoken section in trove.conf, with all parameters required
to configure keystonemiddleware.
This patch will allow to deploy Trove to use Keystone v3
authentification.
Some deprecations:
- trove::api::keystone_tenant is deprecated in favor of trove::keystone::authtoken::project_name.
- trove::api::keystone_user is deprecated in favor of trove::keystone::authtoken::username.
- trove::api::keystone_password is deprecated in favor of trove::keystone::authtoken::password.
- trove::api::identity_uri is deprecated in favor of trove::keystone::authtoken::auth_url.
- trove::api::auth_uri is deprecated in favor of trove::keystone::authtoken::auth_uri.
Change-Id: I808ebda1c4ec3a5b2ed294eb8af4eecafa861051
Closes-Bug: #1604463
This commit adds the transport_url parameters for oslo.messaging. The
url is of the form:
transport://user:pass@host1:port[,hostN:portN]/virtual_host
Where the transport scheme specifies the rpc or notification backend
as one of rabbit, amqp, zmq, etc. Oslo.messaging is deprecating the
host, port, and auth configuration options [1]. All drivers will get
these options via the transport_url.
This patch:
* use oslo::messaging::default resource
* use oslo::messaging::notifications resource
* add parameters for transport_url(s)
* correct config file for amqp backend
* update spec tests
* add feature release note
[1] https://review.openstack.org/#/c/317285/
Change-Id: I8d0132f23aa05ed267ff2d88bce61ce9f20160f5
This patch is aim to add following params in guestagent class:
- root_grant
- root_grant_option
- default_password_length
Change-Id: Iaeed4194b7b9ae895c3a04eb2ed2991fa6984636
Closes-Bug: #1570281
It's not working correctly for now, let's disable it, like we did in
puppet-openstack-integration.
Change-Id: Icfe0da6ed635d82e0504860dbf978035fc983286
Add missing keystone service and endpoint tests during
user and user_role parameters are disabled.
Change-Id: I3cbdec036130634cfffbe162de9c117f48568b85
Closes-Bug: #1587881
In some environments, Trove guests will talk to rabbit via
external VIP using SSL connection and trove services will
communicate to rabbit without ssl from the management network.
Change-Id: Ib5cd00cf92e4e2c23fbed2fd64420a07b0a46f88
Closes-Bug: #1585783
While we were already able to pick an independent auth_name and
service_name; the service_name was defaulting to auth_name. Now it
has a value of its own to be consistent with other modules.
Change-Id: If3f29c1f4efe2eeb5ff9173628403dfcc7f48e57
Related-Bug: #1590040
This commit partially reverts original commit.
use_syslog option is not deprecated and still actual.
This reverts commit 700ddfd674a817c190916890a4a74f82ed82d3c1
Change-Id: Ie7515a45abeb3b0b4a7833bd19a32fbab759765a
Currently configure_user and configure_user_role parameters are set to true.
There should be an option to configure the parameter with appropriate values.
For Example, If we are using Keystone User entries from LDAP,
We can't create/update the user.
Change-Id: Ifecd56e3d1f0d82d45436025497746bb6394e188
Closes-Bug: #1583920
Option "verbose" from group "DEFAULT" is deprecated for removal.
The parameter has no effect.
Deprecated verbose in all classes
Remove verbose in README
Remove verbose from tests.
If this option is not set explicitly, there is no such warning.
Change-Id: Iedbc3ea8824fdef8e1e5434d8be9463704c0579a
Additonal changes:
* switch logging related parameters to $::os_service_default
as they are used in oslo::log
* update unit tests
Change-Id: I1884387b438e3885986d031f95ba323e57aac7ab
This commit adds support for the oslo.messaging amqp rpc_backend
which enables the AMQP 1.0 driver. A proposed feature for the
Newton oslo.messaging release is an update to the AMQP 1.0 driver
to support a stateless messaging interconnect for RPC traffic [1].
This patch:
* use oslo::messaging::amqp resource
* add new parameters for the oslo_messaging_amqp driver
* update spec tests for amqp as alternate rpc_backend
* add feature release note
[1] https://blueprints.launchpad.net/oslo.messaging/+spec/amqp-dispatch-router
Change-Id: I8306c56e86f2f8a8d6da1ecbf5eab674e6b1e8bf
If swift_url is unset, Trove will set it using the Keystone catalog.
Therefore we will default the swift_url setting to use SERVICE_DEFAULT,
so that out of the box configs will use the Keystone catalog.
Change-Id: I7a3fe361ca41fbee9f353be6e2306c1a5c7f7097
This change adds the control_exchange setting for
trove_guestagent_config and trove_config that are included in the api
and guestagent classes.
Change-Id: If0bda0f937330e2fa4304517d06cdd1c02ec9f98
Related-Bug: #1580005
In some environments, Trove guests will talk to rabbit via a different
gateway or VIP and possibly using a different port. This might be done
for security or separation reasons. This change allows the guestagent's
rabbit host(s) and port information to be different than that from the
main cluster.
Change-Id: I2107edd579073d81496821a8ecf23a3c2039b75d
Additonal changes:
* switch database related parameters to $::os_service_default
as they are used in oslo::db
* update unit tests
Change-Id: I2c79261d8000d68521f783b5df9a535ff47ce53d
Additonal changes:
* switch messaging related parameters to $::os_service_default
as they are used in oslo::messaging_rabbit define
* update unit tests
Change-Id: I3f7800f78132fa4c6c639753327ff63cf337c285
These options are unncessary according to Tesora, and they are a
security risk. The nova user has admin privelges. If your use spins up a
trove instance then snapshots it, they'd be able to get admin
credentials in your cloud.
Change-Id: Ie1f46fde9369033315e299e01d5c7f848bdd2696
This patch is aim to following params in puppet-trove class:
- enabled
- trace_sqlalchemy
Change-Id: Icbeedc4a74a8a7d25828ed8c4501c843c5252644
closes-Bug: #1567192
Allow to configure workers for trove conductor.
Keep default from upstream, which is the same as API.
Change-Id: I942addf4347aaf813ef40d2ab39bac69a85a1a33
When rabbit_hosts was set for taskmanager, the guestagent.conf template
was ignoring this setting. This fixes that and moves the configuration
for rabbit into the non-deprecated section. Finally it properly sets
rabbit_ha_queues when using the guestagent template.
Change-Id: Idf22f083541ed307c610c2d019c7022a196bdc0d
Closes-Bug: #1561651
Move all dependency tracking to an external class which simplifies the
relationships and allows managing Trove without necessarily using
packages.
This change also cleans up how the client is handled to make
it more configurable and match other modules.
Finally the reference to the deprecated and non-functional
keystone::python class is dropped.
Change-Id: I943685fbeb114dead80b7465b8f5c564a0bc9fe0
The kombu_reconnect_delay is used when configuring rabbitmq but we are
missing the parameter from the base trove class. This change adds it in
and adds test coverage for the rabbit user, password, host, ssl and
reconnect delay.
Change-Id: I8a5e7f0241a0f41e4f10b40d791f39e37ce82087
Closes-Bug: #1545168
mock is not used anywhere in the module, let's drop it.
This patch will help to hit this bug:
https://launchpad.net/bugs/1492636
Change-Id: I65468b6abebafcd2240b4f5c5f968691a53d54c2
This patch does multiple things regarding auth_* parameters.
1/ We deprecate auth_host, auth_url, auth_port and auth_protocol
If they are set, a nice warning will show up and mention the parameters
will be dropped in a future release. The parameters are still having
effect but will configure old parameters. No worries, they still work.
Just lot of warnings so people will have to use new parameters.
2/ Add new parameters
auth_uri and identity_uri are the way to go!
False by default for now, because we still have old parameters, but in a
later release, they'll be set to a default endpoint, like in other
modules.
3/ Update beaker
We want to test with the new parameters, so let's update beaker
manifests and use auth_uri & identity_uri
This is a first step to use auth_uri & identity_uri that is compliant
with other modules. The next step will be to drop old parameters and set
the right default values for the 2 new params.
Change-Id: I66d5233c8981763a0a341740911fb24dd0e8d479
Closes-bug: #1504653
This change adds the rspec-puppet-facts gem to the spec helper so that
we can centralize the management of the base operating systems that we
support. rspec-puppet-facts allows us to simplify our unit tests and
provides a more complete list of Operating Systems and their associated
facts for the unit tests. With this change we can now loop over and
test CentOS, Debian, Fedora, RedHat, and Ubuntu by simply providing a
list of supported os to rspec-puppet-facts.
Additionally this change includes a central object for managing our
supported os list for rspec-puppet-facts and providing our default facts
like os_service_default. This central object should replace the usage of
@default_facts within the unit tests for each module.
Change-Id: I4770ec921ee7bd608b46aa07eae8b173cb9d554e
amqp_durable_queues option is already defined in trove class,
but is not be used in other trove class.
Close-Bug: #1486319
Change-Id: Ifd4411ce90db26d6f12e714fdc5c54ea507975fd
There are two methods for setting up RabbitMQ HA:
1. Configure rabbit_hosts to multi rabbit hosts.
2. Setting up a loadbalancer in front of RabbitMQ cluster,
provide a unique address in rabbit_host
In current, rabbit_ha_queues option is controled by rabbit_hosts IF
conditional statement. But when users want to use the second method:
changing rabbit_ha_queues to true, but they don't use rabbit_hosts
option, this logic will not work.
This patch adds an rabbit_ha_queues option, set it to undef by
default for forward compatbility.
Close-Bug: #1485287
Change-Id: Ib8fe16182188729100ef4704466c4d42d31ff510