openstack/puppet-vitrage
Code Issues Proposed changes

Merge "Do not test detail of keystone::auth::service_identity"

Browse Source
This commit is contained in:
Zuul 2022-01-24 17:42:06 +00:00 committed by Gerrit Code Review
commit f7aa479c26
1 changed files with 48 additions and 102 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

150
spec/classes/vitrage_keystone_auth_spec.rb
View File

@ -5,130 +5,76 @@
require 'spec_helper' require 'spec_helper'
describe 'vitrage::keystone::auth' do describe 'vitrage::keystone::auth' do
let :facts do
@default_facts.merge({ :osfamily => 'Debian' })
end
shared_examples_for 'vitrage::keystone::auth' do shared_examples_for 'vitrage::keystone::auth' do
context 'with default class parameters' do context 'with default class parameters' do
let :params do let :params do
{ :password => 'vitrage_password', { :password => 'vitrage_password' }
:tenant => 'foobar' }
end end
it { is_expected.to contain_keystone_user('vitrage').with( it { is_expected.to contain_keystone__resource__service_identity('vitrage').with(
:ensure => 'present', :configure_user => true,
:password => 'vitrage_password', :configure_user_role => true,
) } :configure_endpoint => true,
:service_name => 'vitrage',
it { is_expected.to contain_keystone_user_role('vitrage@foobar').with( :service_type => 'rca',
:ensure => 'present', :service_description => 'Root Cause Analysis Service',
:roles => ['admin'] :region => 'RegionOne',
)} :auth_name => 'vitrage',
:password => 'vitrage_password',
it { is_expected.to contain_keystone_service('vitrage::rca').with( :email => 'vitrage@localhost',
:ensure => 'present', :tenant => 'services',
:description => 'Root Cause Analysis Service' :public_url => 'http://127.0.0.1:8999',
) } :internal_url => 'http://127.0.0.1:8999',
:admin_url => 'http://127.0.0.1:8999',
it { is_expected.to contain_keystone_endpoint('RegionOne/vitrage::rca').with(
:ensure => 'present',
:public_url => 'http://127.0.0.1:8999',
:admin_url => 'http://127.0.0.1:8999',
:internal_url => 'http://127.0.0.1:8999',
) } ) }
end end
context 'when overriding URL parameters' do context 'when overriding parameters' do
let :params do let :params do
{ :password => 'vitrage_password', { :password => 'vitrage_password',
:public_url => 'https://10.10.10.10:80', :auth_name => 'alt_vitrage',
:internal_url => 'http://10.10.10.11:81', :email => 'alt_vitrage@alt_localhost',
:admin_url => 'http://10.10.10.12:81', } :tenant => 'alt_service',
end :configure_endpoint => false,
it { is_expected.to contain_keystone_endpoint('RegionOne/vitrage::rca').with(
:ensure => 'present',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
) }
end
context 'when overriding auth name' do
let :params do
{ :password => 'foo',
:auth_name => 'vitrageany' }
end
it { is_expected.to contain_keystone_user('vitrageany') }
it { is_expected.to contain_keystone_user_role('vitrageany@services') }
it { is_expected.to contain_keystone_service('vitrageany::rca') }
it { is_expected.to contain_keystone_endpoint('RegionOne/vitrageany::rca') }
end
context 'when overriding service name' do
let :params do
{ :service_name => 'vitrage_service',
:auth_name => 'vitrage',
:password => 'vitrage_password' }
end
it { is_expected.to contain_keystone_user('vitrage') }
it { is_expected.to contain_keystone_user_role('vitrage@services') }
it { is_expected.to contain_keystone_service('vitrage_service::rca') }
it { is_expected.to contain_keystone_endpoint('RegionOne/vitrage_service::rca') }
end
context 'when disabling user configuration' do
let :params do
{
:password => 'vitrage_password',
:configure_user => false
}
end
it { is_expected.not_to contain_keystone_user('vitrage') }
it { is_expected.to contain_keystone_user_role('vitrage@services') }
it { is_expected.to contain_keystone_service('vitrage::rca').with(
:ensure => 'present',
:description => 'Root Cause Analysis Service'
) }
end
context 'when disabling user and user role configuration' do
let :params do
{
:password => 'vitrage_password',
:configure_user => false, :configure_user => false,
:configure_user_role => false :configure_user_role => false,
} :service_description => 'Alternative Root Cause Analysis Service',
:service_name => 'alt_service',
:service_type => 'alt_rca',
:region => 'RegionTwo',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81' }
end end
it { is_expected.not_to contain_keystone_user('vitrage') } it { is_expected.to contain_keystone__resource__service_identity('vitrage').with(
it { is_expected.not_to contain_keystone_user_role('vitrage@services') } :configure_user => false,
it { is_expected.to contain_keystone_service('vitrage::rca').with( :configure_user_role => false,
:ensure => 'present', :configure_endpoint => false,
:description => 'Root Cause Analysis Service' :service_name => 'alt_service',
:service_type => 'alt_rca',
:service_description => 'Alternative Root Cause Analysis Service',
:region => 'RegionTwo',
:auth_name => 'alt_vitrage',
:password => 'vitrage_password',
:email => 'alt_vitrage@alt_localhost',
:tenant => 'alt_service',
:public_url => 'https://10.10.10.10:80',
:internal_url => 'http://10.10.10.11:81',
:admin_url => 'http://10.10.10.12:81',
) } ) }
end end
end end
on_supported_os({ on_supported_os({
:supported_os => OSDefaults.get_supported_os :supported_os => OSDefaults.get_supported_os
}).each do |os,facts| }).each do |os,facts|
context "on #{os}" do context "on #{os}" do
let (:facts) do let (:facts) do
facts.merge!(OSDefaults.get_facts({})) facts.merge!(OSDefaults.get_facts())
end end
it_configures 'vitrage::keystone::auth' it_behaves_like 'vitrage::keystone::auth'
end end
end end
end end