openstack
/
puppet-watcher
Code Issues Proposed changes

Merge "Stop listening at 0.0.0.0 by default"

This commit is contained in:
Zuul 2022-08-15 15:44:21 +00:00 committed by Gerrit Code Review
parent 652a0199d4 388e3a2dfb
commit 1b51997ee0
3 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
manifests/api.pp
View File

@ -29,11 +29,11 @@
# [*max_limit*]
# (Optional)The maximum number of items returned in a single response from a
# collection resource.
# Defaults to $::os_service_default
# Defaults to $::os_service_default.
#
# [*bind_host*]
# (Optional) Listen IP for the watcher API server.
# Defaults to '0.0.0.0'.
# Defaults to $::os_service_default.
#
# [*workers*]
# (Optional) Number of worker processors to for the Watcher API service.
@ -170,7 +170,7 @@ class watcher::api (
$manage_service = true,
$port = 9322,
$max_limit = $::os_service_default,
$bind_host = '0.0.0.0',
$bind_host = $::os_service_default,
$workers = $::os_workers,
$enable_ssl_api = $::os_service_default,
$service_name = $::watcher::params::api_service_name,

6
releasenotes/notes/default-bind_host-7ab540eba59c4135.yaml Normal file
View File

@ -0,0 +1,6 @@
---
upgrade:
- |
Default value of the ``watcher::api::bind_host`` parameter has been changed
from ``0.0.0.0`` to the service default(``127.0.0.1``). The parameter
should be configured propelry during upgrade.

2
spec/classes/watcher_api_spec.rb
View File

@ -52,7 +52,7 @@ describe 'watcher::api' do
it 'should configure the api configurations section when enabled' do
is_expected.to contain_watcher_config('api/port').with_value(9322)
is_expected.to contain_watcher_config('api/max_limit').with_value('<SERVICE DEFAULT>')
is_expected.to contain_watcher_config('api/host').with_value('0.0.0.0')
is_expected.to contain_watcher_config('api/host').with_value('<SERVICE DEFAULT>')
is_expected.to contain_watcher_config('api/workers').with_value(2)
is_expected.to contain_watcher_config('api/enable_ssl_api').with_value('<SERVICE DEFAULT>')
end