apache+mod_wsgi: Disable SSL by default

During the previous cycle, a warning message was added to inform users
of this change.

Now the default value is updated so that SSL is disabled by default.

Change-Id: I72ddec25f8a7d747ab2816f2b76aae2f07ccfeba

manifests/wsgi/apache.pp

@@ -38,7 +38,7 @@
 #
 #   [*ssl*]
 #     Use ssl ? (boolean)
-#     Optional. Defaults to true
+#     Optional. Defaults to false
 #
 #   [*workers*]
 #     Number of WSGI workers to spawn.
@@ -101,7 +101,7 @@ class watcher::wsgi::apache (
   $port                        = 9322,
   $bind_host                   = undef,
   $path                        = '/',
-  $ssl                         = undef,
+  $ssl                         = false,
   $workers                     = $::os_workers,
   $ssl_cert                    = undef,
   $ssl_key                     = undef,
@@ -119,11 +119,6 @@ class watcher::wsgi::apache (
   $custom_wsgi_process_options = {},
 ) {
 
-  if $ssl == undef {
-    warning('Default of the ssl parameter will be changed in a future release')
-  }
-  $ssl_real = pick($ssl, true)
-
   include watcher::deps
   include watcher::params
 
@@ -136,7 +131,7 @@ class watcher::wsgi::apache (
     path                        => $path,
     priority                    => $priority,
     servername                  => $servername,
-    ssl                         => $ssl_real,
+    ssl                         => $ssl,
     ssl_ca                      => $ssl_ca,
     ssl_cert                    => $ssl_cert,
     ssl_certs_dir               => $ssl_certs_dir,

releasenotes/notes/disable-apache-ssl-2599fd907b0ce8c2.yaml

@@ -0,0 +1,5 @@
+---
+upgrade:
+  - |
+    Default value of the ``watcher::wsgi::apache::ssl`` parameter has been
+    changed from ``true`` to ``false`` and now ssl is disabled by default.

spec/classes/watcher_wsgi_apache_spec.rb

@@ -10,7 +10,7 @@ describe 'watcher::wsgi::apache' do
         :group                       => 'watcher',
         :path                        => '/',
         :servername                  => facts[:fqdn],
-        :ssl                         => true,
+        :ssl                         => false,
         :threads                     => 1,
         :user                        => 'watcher',
         :workers                     => facts[:os_workers],
@@ -31,7 +31,7 @@ describe 'watcher::wsgi::apache' do
           :servername                  => 'dummy.host',
           :bind_host                   => '10.42.51.1',
           :port                        => 12345,
-          :ssl                         => false,
+          :ssl                         => true,
           :wsgi_process_display_name   => 'watcher',
           :workers                     => 37,
           :access_log_file             => '/var/log/httpd/access_log',
@@ -49,7 +49,7 @@ describe 'watcher::wsgi::apache' do
         :group                       => 'watcher',
         :path                        => '/',
         :servername                  => 'dummy.host',
-        :ssl                         => false,
+        :ssl                         => true,
         :threads                     => 1,
         :user                        => 'watcher',
         :workers                     => 37,