Make password required

... because it is actually required so that zaqar can authenticate with
keystone.

Depends-on: https://review.opendev.org/903852
Change-Id: I8e5ea733f10abfdcc5da0699311222cfbe6cbf4e

manifests/keystone/trust.pp

@@ -4,14 +4,13 @@
 #
 # === Parameters
 #
+# [*password*]
+#   (Required) Password of the trust user
+#
 # [*username*]
 #   (Optional) The name of the trust user
 #   Defaults to 'zaqar'
 #
-# [*password*]
-#   (Optional) Password to create for the trust user
-#   Defaults to $facts['os_service_default']
-#
 # [*auth_url*]
 #   (Optional) The URL to use for authentication.
 #   Defaults to 'http://localhost:5000'
@@ -29,8 +28,8 @@
 #   Defaults to 'password'
 #
 class zaqar::keystone::trust(
+  $password,
   $username         = 'zaqar',
-  $password                       = $facts['os_service_default'],
   $auth_url         = 'http://localhost:5000',
   $user_domain_name = 'Default',
   $auth_section     = $facts['os_service_default'],

spec/classes/zaqar_init_spec.rb

@@ -4,6 +4,9 @@ describe 'zaqar' do
     let :pre_condition do
       "class { 'zaqar::keystone::authtoken':
          password => 'password',
+       }
+       class { 'zaqar::keystone::trust':
+         password => 'password',
        }"
     end
     let :req_params do

spec/classes/zaqar_keystone_trust_spec.rb

@@ -3,16 +3,31 @@ require 'spec_helper'
 describe 'zaqar::keystone::trust' do
 
   shared_examples_for 'zaqar::keystone::trust' do
-    describe 'with custom values' do
     let :params do
-        {
+      { :password => 'secret' }
+    end
+
+    context 'with default values' do
+      it 'configures default values' do
+        is_expected.to contain_zaqar_config('trustee/username').with_value('zaqar')
+        is_expected.to contain_zaqar_config('trustee/password').with_value('secret').with_secret(true)
+        is_expected.to contain_zaqar_config('trustee/auth_url').with_value('http://localhost:5000')
+        is_expected.to contain_zaqar_config('trustee/user_domain_name').with_value('Default')
+        is_expected.to contain_zaqar_config('trustee/auth_section').with_value('<SERVICE DEFAULT>')
+        is_expected.to contain_zaqar_config('trustee/auth_type').with_value('password')
+      end
+    end
+
+    context 'with custom values' do
+      before :each do
+        params.merge!({
           :username         => 'user',
           :password         => 'secret',
           :auth_url         => 'http://there',
           :user_domain_name => 'domain',
           :auth_section     => 'keystone',
           :auth_type        => 'token',
-        }
+        })
       end
 
       it 'configures custom values' do

spec/classes/zaqar_management_mongodb_spec.rb

@@ -7,6 +7,9 @@ describe 'zaqar::management::mongodb' do
       "class { 'zaqar::keystone::authtoken':
          password => 'foo',
        }
+       class { 'zaqar::keystone::trust':
+         password => 'foo',
+       }
        class { 'zaqar':
          management_store => 'mongodb',
        }"

spec/classes/zaqar_management_redis_spec.rb

@@ -7,6 +7,9 @@ describe 'zaqar::management::redis' do
       "class { 'zaqar::keystone::authtoken':
          password => 'foo',
        }
+       class { 'zaqar::keystone::trust':
+         password => 'foo',
+       }
        class { 'zaqar':
          management_store =>'redis',
        }"

spec/classes/zaqar_management_sqlalchemy_spec.rb

@@ -7,6 +7,9 @@ describe 'zaqar::management::sqlalchemy' do
       "class { 'zaqar::keystone::authtoken':
          password => 'foo',
        }
+       class { 'zaqar::keystone::trust':
+         password => 'foo',
+       }
        class { 'zaqar':
          management_store =>'sqlalchemy',
        }"

spec/classes/zaqar_messaging_mongodb_spec.rb

@@ -7,6 +7,9 @@ describe 'zaqar::messaging::mongodb' do
       "class { 'zaqar::keystone::authtoken':
          password => 'foo',
        }
+       class { 'zaqar::keystone::trust':
+         password => 'foo',
+       }
        class { 'zaqar':
          message_store => 'mongodb'
        }"

spec/classes/zaqar_messaging_redis_spec.rb

@@ -7,11 +7,14 @@ describe 'zaqar::messaging::redis' do
       "class { 'zaqar::keystone::authtoken':
          password => 'foo',
        }
+       class { 'zaqar::keystone::trust':
+         password => 'foo',
+       }
        class { 'zaqar':
          message_store =>'redis',
        }"
-
     end
+
     let :req_params do
       {
         :uri   => 'redis://127.0.0.1:6379',

spec/classes/zaqar_messaging_swift_spec.rb

@@ -7,6 +7,9 @@ describe 'zaqar::messaging::swift' do
       "class { 'zaqar::keystone::authtoken':
          password => 'foo',
        }
+       class { 'zaqar::keystone::trust':
+         password => 'foo',
+       }
        class { 'zaqar':
          message_store =>'swift',
        }"

spec/classes/zaqar_server_spec.rb

@@ -7,7 +7,10 @@ describe 'zaqar::server' do
         "class { 'zaqar::keystone::authtoken':
            password => 'foo',
          }
-         class {'::zaqar': }"
+        class { 'zaqar::keystone::trust':
+           password => 'foo',
+         }
+         class { 'zaqar': }"
       end
 
       it { is_expected.to contain_service(platform_params[:zaqar_service_name]).with(

spec/defines/zaqar_server_instance_spec.rb

@@ -11,7 +11,10 @@ describe 'zaqar::server_instance' do
         "class { 'zaqar::keystone::authtoken':
            password => 'foo',
          }
-         class {'::zaqar': }"
+         class { 'zaqar::keystone::trust':
+           password => 'foo',
+         }
+         class { 'zaqar': }"
       end
 
       let :params do