openstack/pycadf
Code Issues Proposed changes

Update hacking for Python3

Browse Source 
The repo is Python 3 now, so update hacking to version 3.0 which
supports Python 3.

Blacklist W503, W504
Fix other problems found

Change-Id: Ic0391ae45b9d6d1ee5e2c1df81d85e655250a51d
This commit is contained in:
Andreas Jaeger 2020-03-27 21:07:15 +01:00 committed by Andreas Jaeger
parent 91073f4ea1
commit 61b6e87de7
4 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pycadf/cadftaxonomy.py
View File

@ -89,6 +89,7 @@ OUTCOME_TAXONOMY = frozenset([
def is_valid_outcome(value): def is_valid_outcome(value):
return value in OUTCOME_TAXONOMY return value in OUTCOME_TAXONOMY
SERVICE_SECURITY = 'service/security' SERVICE_SECURITY = 'service/security'
SERVICE_KEYMGR = 'service/security/keymanager' SERVICE_KEYMGR = 'service/security/keymanager'
ACCOUNT_USER = 'service/security/account/user' ACCOUNT_USER = 'service/security/account/user'

1
pycadf/cadftype.py
View File

@ -35,6 +35,7 @@ VALID_EVENTTYPES = frozenset([
def is_valid_eventType(value): def is_valid_eventType(value):
return value in VALID_EVENTTYPES return value in VALID_EVENTTYPES
# valid cadf:Event record "Reporter" roles # valid cadf:Event record "Reporter" roles
REPORTER_ROLE_OBSERVER = 'observer' REPORTER_ROLE_OBSERVER = 'observer'
REPORTER_ROLE_MODIFIER = 'modifier' REPORTER_ROLE_MODIFIER = 'modifier'

2
test-requirements.txt
View File

@ -2,7 +2,7 @@
# of appearance. Changing the order has an impact on the overall integration # of appearance. Changing the order has an impact on the overall integration
# process, which may cause wedges in the gate later. # process, which may cause wedges in the gate later.
# Hacking already pins down pep8, pyflakes and flake8 # Hacking already pins down pep8, pyflakes and flake8
hacking<0.11,>=0.10.0 hacking>=3.0,<3.1.0 # Apache-2.0
flake8-docstrings==0.2.1.post1 # MIT flake8-docstrings==0.2.1.post1 # MIT
coverage!=4.4,>=4.0 # Apache-2.0 coverage!=4.4,>=4.0 # Apache-2.0

4
tox.ini
View File

@ -54,7 +54,9 @@ show-source = True
# D208: Docstring is over-indented # D208: Docstring is over-indented
# D400: First line should end with a period # D400: First line should end with a period
# D401: First line should be in imperative mood # D401: First line should be in imperative mood
ignore = H405,D100,D101,D102,D103,D104,D105,D200,D202,D203,D204,D205,D208,D400,D401 # W503 line break before binary operator
# W504 line break after binary operator
ignore = H405,D100,D101,D102,D103,D104,D105,D200,D202,D203,D204,D205,D208,D400,D401,W503,W504
exclude = .tox,dist,doc,*.egg,build exclude = .tox,dist,doc,*.egg,build
[testenv:lower-constraints] [testenv:lower-constraints]