Fix gate

* Update pike to train
* Fix pep8
* Mark jobs based on legacy jobs non-voting until we can replace them

Change-Id: Ia83ad102bb5c096b01ce73bffb86d44732d2c784

.zuul.yaml

@@ -15,8 +15,6 @@
         - openstack-tox-py36
         - openstack-tox-py37
         - pyeclib-tox-py27-centos-7
-        - libec-pyeclib-unit-centos-7
-        - libec-pyeclib-unit
 
 - job:
     name: pyeclib-tox-py27-centos-7
@@ -36,6 +34,7 @@
     required-projects:
       - openstack/liberasurecode
       - openstack/pyeclib
+    voting: false
 
 - job:
     name: libec-pyeclib-unit
@@ -45,3 +44,4 @@
     required-projects:
       - openstack/liberasurecode
       - openstack/pyeclib
+    voting: false

pyeclib/utils.py

@@ -51,7 +51,7 @@ def import_class(import_str):
         __import__(mod_str)
         return getattr(sys.modules[mod_str], class_str)
     except (ValueError, AttributeError):
-        raise ImportError('Class %s cannot be found (%)' %
+        raise ImportError('Class %s cannot be found (%s)' %
                           (class_str,
                            traceback.format_exception(*sys.exc_info())))
 

test/test_pyeclib_c.py

@@ -152,7 +152,7 @@ class TestPyECLib(unittest.TestCase):
         whole_file_bytes = self.get_tmp_file(file_size).read()
 
         timer.start()
-        for l in range(iterations):
+        for i in range(iterations):
             pyeclib_c.encode(handle, whole_file_bytes)
         tsum = timer.stop_and_return()
 

tools/test-setup.sh

@@ -15,7 +15,7 @@ function is_rhel7 {
 if is_rhel7; then
     # Install CentOS OpenStack repos so that we have access to some extra
     # packages.
-    sudo yum install -y centos-release-openstack-pike
+    sudo yum install -y centos-release-openstack-train
     # Now that RDO repositories are enabled, install missing
     # packages.
     sudo yum install -y liberasurecode-devel yasm