Merge "Add to_dict method to EntityFormatter."

This commit is contained in:
Jenkins 2015-10-24 02:22:40 +00:00 committed by Gerrit Code Review
commit 7b15294a15
2 changed files with 63 additions and 0 deletions

View File

@ -48,3 +48,7 @@ class EntityFormatter(object):
for name, value in zip(self.columns, data):
table.add_row((name, value))
return table.get_string(fields=('Field', 'Value'))
def to_dict(self):
columns, data = self._get_formatted_entity()
return dict((key, value) for (key, value) in zip(columns, data))

View File

@ -0,0 +1,59 @@
import testtools
from barbicanclient import formatter
class EntityFormatter(formatter.EntityFormatter):
columns = ("Column A",
"Column B",
"Column C")
def _get_formatted_data(self):
data = (self._attr_a,
self._attr_b,
self._attr_c)
return data
class Entity(EntityFormatter):
def __init__(self, attr_a, attr_b, attr_c):
self._attr_a = attr_a
self._attr_b = attr_b
self._attr_c = attr_c
class TestFormatter(testtools.TestCase):
def test_should_get_list_objects(self):
entity_1 = Entity('test_attr_a_1', 'test_attr_b_1', 'test_attr_c_1')
entity_2 = Entity('test_attr_a_2', 'test_attr_b_2', 'test_attr_c_2')
columns, data = EntityFormatter._list_objects([entity_1, entity_2])
self.assertEqual(columns, ('Column A', 'Column B', 'Column C'))
self.assertEqual([e for e in data],
[('test_attr_a_1', 'test_attr_b_1', 'test_attr_c_1'),
('test_attr_a_2', 'test_attr_b_2', 'test_attr_c_2')])
def test_should_get_list_objects_empty(self):
columns, data = EntityFormatter._list_objects([])
self.assertEqual(columns, [])
self.assertEqual([e for e in data], [])
def test_should_get_str(self):
entity = Entity('test_attr_a_1', 'test_attr_b_1', 'test_attr_c_1')
self.assertEqual(str(entity),
'+----------+---------------+\n'
'| Field | Value |\n'
'+----------+---------------+\n'
'| Column A | test_attr_a_1 |\n'
'| Column B | test_attr_b_1 |\n'
'| Column C | test_attr_c_1 |\n'
'+----------+---------------+')
def test_should_to_dict(self):
entity = Entity('test_attr_a_1', 'test_attr_b_1', 'test_attr_c_1')
self.assertEqual(entity.to_dict(),
{'Column A': 'test_attr_a_1',
'Column B': 'test_attr_b_1',
'Column C': 'test_attr_c_1'})