openstack/python-brick-cinderclient-ext
Code Issues Proposed changes

Clean imports in code

Browse Source 
This patch set modifies lines which are importing objects
instead of modules. As per openstack import guide lines, user should
import modules in a file not objects.

http://docs.openstack.org/developer/hacking/#imports

Change-Id: Ib80b7967889987dc2c78f85d6b006d84ef96fe15
This commit is contained in:
Cao Xuan Hoang
2017-02-06 13:42:44 +07:00
parent 39c714c06e
commit 3b843f8ed8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
brick_cinderclient_ext/tests/unit/test_brick_client.py
View File

@@ -15,7 +15,7 @@ import mock
from oslotest import base from oslotest import base
from brick_cinderclient_ext import client from brick_cinderclient_ext import client
from cinderclient.v2.volumes import Volume from cinderclient.v2 import volumes
class TestBrickClient(base.BaseTestCase): class TestBrickClient(base.BaseTestCase):
@@ -31,7 +31,7 @@ class TestBrickClient(base.BaseTestCase):
conn_data = {'key': 'value'} conn_data = {'key': 'value'}
connection = {'driver_volume_type': protocol, 'data': conn_data} connection = {'driver_volume_type': protocol, 'data': conn_data}
self.mock_vc.volumes.initialize_connection.return_value = connection self.mock_vc.volumes.initialize_connection.return_value = connection
fake_vol = Volume(self, { fake_vol = volumes.Volume(self, {
'id': self.volume_id, 'id': self.volume_id,
'name': 'fake-volume', 'name': 'fake-volume',
'status': 'in-use', 'status': 'in-use',