openstack/python-ceilometerclient
Code Issues Proposed changes

Use assertTrue/False instead of assertEqual(T/F)

Browse Source 
The usage of assertEqual(True/False, ***) should be changed
to a meaningful format of assertTrue/False(***).

Change-Id: Iabf8d017b47025309f186afb5e30b8ad990c2448
Closes-Bug:#1512207
This commit is contained in:
Swapnil Kulkarni (coolsvap)
2016-01-07 12:37:26 +05:30
parent 6097b0ce2e
commit c4abadfee8
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
ceilometerclient/tests/unit/test_shell.py
View File

@@ -210,7 +210,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'true', 'alarm-list']
self.assertIsNone(ceilometer_shell.main(args))
args, kwargs = mocked_client.call_args
self.assertEqual(False, kwargs.get('verify'))
self.assertFalse(kwargs.get('verify'))
@mock.patch.object(ks_session, 'Session')
@mock.patch('ceilometerclient.client.AuthPlugin.redirect_to_aodh_endpoint')
@@ -220,7 +220,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'true', 'alarm-list']
self.assertRaises(exc.CommandError, ceilometer_shell.main, args)
args, kwargs = mocked_session.call_args
self.assertEqual(False, kwargs.get('verify'))
self.assertFalse(kwargs.get('verify'))
@mock.patch.object(api_client, 'HTTPClient')
@mock.patch('ceilometerclient.client.AuthPlugin.redirect_to_aodh_endpoint')
@@ -229,7 +229,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'false', 'alarm-list']
self.assertIsNone(ceilometer_shell.main(args))
args, kwargs = mocked_client.call_args
self.assertEqual(True, kwargs.get('verify'))
self.assertTrue(kwargs.get('verify'))
@mock.patch.object(ks_session, 'Session')
@mock.patch('ceilometerclient.client.AuthPlugin.redirect_to_aodh_endpoint')
@@ -239,7 +239,7 @@ class ShellInsecureTest(ShellTestBase):
args = ['--debug', '--os-insecure', 'false', 'alarm-list']
self.assertRaises(exc.CommandError, ceilometer_shell.main, args)
args, kwargs = mocked_session.call_args
self.assertEqual(True, kwargs.get('verify'))
self.assertTrue(kwargs.get('verify'))
class ShellEndpointTest(ShellTestBase):

2
ceilometerclient/tests/unit/v2/test_capabilities.py
View File

@@ -55,4 +55,4 @@ class CapabilitiesManagerTest(testtools.TestCase):
def test_capabilities_get(self):
capabilities = self.mgr.get()
self.http_client.assert_called('GET', '/v2/capabilities')
self.assertEqual(True, capabilities.api['alarms:query:complex'])
self.assertTrue(capabilities.api['alarms:query:complex'])