Fixes bug 1298528 Due to WSME re-ordering of query parameters, in the mixed case any parameterized aggregates must be specified in the URL first, prior to any unparameterized aggregates. Otherwise the aggregate parameter will be associated with the wrong aggregate function. Change-Id: Ib2c76d03a4fc91d13074a03caade2c776d2309b3
205 lines
6.3 KiB
Python
205 lines
6.3 KiB
Python
# Copyright 2012 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
from ceilometerclient.tests import utils
|
|
import ceilometerclient.v2.statistics
|
|
|
|
base_url = '/v2/meters/instance/statistics'
|
|
qry = ('q.field=resource_id&q.field=source&q.op=&q.op='
|
|
'&q.type=&q.type=&q.value=foo&q.value=bar')
|
|
period = '&period=60'
|
|
groupby = '&groupby=resource_id'
|
|
aggregate_query = ("aggregate.func=cardinality&aggregate.param=resource_id"
|
|
"&aggregate.func=count")
|
|
samples = [
|
|
{u'count': 135,
|
|
u'duration_start': u'2013-02-04T10:51:42',
|
|
u'min': 1.0,
|
|
u'max': 1.0,
|
|
u'duration_end':
|
|
u'2013-02-05T15:46:09',
|
|
u'duration': 1734.0,
|
|
u'avg': 1.0,
|
|
u'sum': 135.0},
|
|
]
|
|
groupby_samples = [
|
|
{u'count': 135,
|
|
u'duration_start': u'2013-02-04T10:51:42',
|
|
u'min': 1.0,
|
|
u'max': 1.0,
|
|
u'duration_end':
|
|
u'2013-02-05T15:46:09',
|
|
u'duration': 1734.0,
|
|
u'avg': 1.0,
|
|
u'sum': 135.0,
|
|
u'groupby': {u'resource_id': u'foo'}
|
|
},
|
|
{u'count': 12,
|
|
u'duration_start': u'2013-02-04T10:51:42',
|
|
u'min': 1.0,
|
|
u'max': 1.0,
|
|
u'duration_end':
|
|
u'2013-02-05T15:46:09',
|
|
u'duration': 1734.0,
|
|
u'avg': 1.0,
|
|
u'sum': 12.0,
|
|
u'groupby': {u'resource_id': u'bar'}
|
|
},
|
|
]
|
|
aggregate_samples = [
|
|
{u'aggregate': {u'cardinality/resource_id': 4.0, u'count': 2.0},
|
|
u'count': 2,
|
|
u'duration': 0.442451,
|
|
u'duration_end': u'2014-03-12T14:00:21.774154',
|
|
u'duration_start': u'2014-03-12T14:00:21.331703',
|
|
u'groupby': None,
|
|
u'period': 0,
|
|
u'period_end': u'2014-03-12T14:00:21.774154',
|
|
u'period_start': u'2014-03-12T14:00:21.331703',
|
|
u'unit': u'instance',
|
|
},
|
|
]
|
|
fixtures = {
|
|
base_url:
|
|
{
|
|
'GET': (
|
|
{},
|
|
samples
|
|
),
|
|
},
|
|
'%s?%s' % (base_url, qry):
|
|
{
|
|
'GET': (
|
|
{},
|
|
samples
|
|
),
|
|
},
|
|
'%s?%s%s' % (base_url, qry, period):
|
|
{
|
|
'GET': (
|
|
{},
|
|
samples
|
|
),
|
|
},
|
|
'%s?%s%s' % (base_url, qry, groupby):
|
|
{
|
|
'GET': (
|
|
{},
|
|
groupby_samples
|
|
),
|
|
},
|
|
'%s?%s' % (base_url, aggregate_query):
|
|
{
|
|
'GET': (
|
|
{},
|
|
aggregate_samples
|
|
),
|
|
}
|
|
}
|
|
|
|
|
|
class StatisticsManagerTest(utils.BaseTestCase):
|
|
|
|
def setUp(self):
|
|
super(StatisticsManagerTest, self).setUp()
|
|
self.api = utils.FakeAPI(fixtures)
|
|
self.mgr = ceilometerclient.v2.statistics.StatisticsManager(self.api)
|
|
|
|
def test_list_by_meter_name(self):
|
|
stats = list(self.mgr.list(meter_name='instance'))
|
|
expect = [
|
|
('GET', '/v2/meters/instance/statistics', {}, None),
|
|
]
|
|
self.assertEqual(self.api.calls, expect)
|
|
self.assertEqual(len(stats), 1)
|
|
self.assertEqual(stats[0].count, 135)
|
|
|
|
def test_list_by_meter_name_extended(self):
|
|
stats = list(self.mgr.list(meter_name='instance',
|
|
q=[
|
|
{"field": "resource_id",
|
|
"value": "foo"},
|
|
{"field": "source",
|
|
"value": "bar"},
|
|
]))
|
|
expect = [
|
|
('GET',
|
|
'%s?%s' % (base_url, qry), {}, None),
|
|
]
|
|
self.assertEqual(self.api.calls, expect)
|
|
self.assertEqual(len(stats), 1)
|
|
self.assertEqual(stats[0].count, 135)
|
|
|
|
def test_list_by_meter_name_with_period(self):
|
|
stats = list(self.mgr.list(meter_name='instance',
|
|
q=[
|
|
{"field": "resource_id",
|
|
"value": "foo"},
|
|
{"field": "source",
|
|
"value": "bar"},
|
|
],
|
|
period=60))
|
|
expect = [
|
|
('GET',
|
|
'%s?%s%s' % (base_url, qry, period), {}, None),
|
|
]
|
|
self.assertEqual(self.api.calls, expect)
|
|
self.assertEqual(len(stats), 1)
|
|
self.assertEqual(stats[0].count, 135)
|
|
|
|
def test_list_by_meter_name_with_groupby(self):
|
|
stats = list(self.mgr.list(meter_name='instance',
|
|
q=[
|
|
{"field": "resource_id",
|
|
"value": "foo"},
|
|
{"field": "source",
|
|
"value": "bar"},
|
|
],
|
|
groupby=['resource_id']))
|
|
expect = [
|
|
('GET',
|
|
'%s?%s%s' % (base_url, qry, groupby), {}, None),
|
|
]
|
|
self.assertEqual(self.api.calls, expect)
|
|
self.assertEqual(len(stats), 2)
|
|
self.assertEqual(stats[0].count, 135)
|
|
self.assertEqual(stats[1].count, 12)
|
|
self.assertEqual(stats[0].groupby.get('resource_id'), 'foo')
|
|
self.assertEqual(stats[1].groupby.get('resource_id'), 'bar')
|
|
|
|
def test_list_by_meter_name_with_aggregates(self):
|
|
aggregates = [
|
|
{
|
|
'func': 'count',
|
|
},
|
|
{
|
|
'func': 'cardinality',
|
|
'param': 'resource_id',
|
|
},
|
|
]
|
|
stats = list(self.mgr.list(meter_name='instance',
|
|
aggregates=aggregates))
|
|
expect = [
|
|
('GET',
|
|
'%s?%s' % (base_url, aggregate_query), {}, None),
|
|
]
|
|
self.assertEqual(expect, self.api.calls)
|
|
self.assertEqual(1, len(stats))
|
|
self.assertEqual(2, stats[0].count)
|
|
self.assertEqual(2.0, stats[0].aggregate.get('count'))
|
|
self.assertEqual(4.0, stats[0].aggregate.get(
|
|
'cardinality/resource_id',
|
|
))
|