diff --git a/cinderclient/tests/unit/v3/fakes.py b/cinderclient/tests/unit/v3/fakes.py index 7dfee24d1..203b3aceb 100644 --- a/cinderclient/tests/unit/v3/fakes.py +++ b/cinderclient/tests/unit/v3/fakes.py @@ -401,16 +401,16 @@ class FakeHTTPClient(fakes_base.FakeHTTPClient): return (200, {}, {'group_specs': {'k': 'v'}}) def delete_group_types_1_group_specs_k(self, **kw): - return(204, {}, None) + return (204, {}, None) def delete_group_types_1_group_specs_m(self, **kw): - return(204, {}, None) + return (204, {}, None) def delete_group_types_1(self, **kw): return (202, {}, None) def delete_group_types_3_group_specs_k(self, **kw): - return(204, {}, None) + return (204, {}, None) def delete_group_types_3(self, **kw): return (202, {}, None) diff --git a/cinderclient/tests/unit/v3/fakes_base.py b/cinderclient/tests/unit/v3/fakes_base.py index b85401d7f..9702b42c2 100644 --- a/cinderclient/tests/unit/v3/fakes_base.py +++ b/cinderclient/tests/unit/v3/fakes_base.py @@ -772,16 +772,16 @@ class FakeHTTPClient(base_client.HTTPClient): return (200, {}, {'extra_specs': {'k': 'v'}}) def delete_types_1_extra_specs_k(self, **kw): - return(204, {}, None) + return (204, {}, None) def delete_types_1_extra_specs_m(self, **kw): - return(204, {}, None) + return (204, {}, None) def delete_types_1(self, **kw): return (202, {}, None) def delete_types_3_extra_specs_k(self, **kw): - return(204, {}, None) + return (204, {}, None) def delete_types_3(self, **kw): return (202, {}, None) @@ -936,13 +936,13 @@ class FakeHTTPClient(base_client.HTTPClient): {'restore': _stub_restore()}) def post_backups_76a17945_3c6f_435c_975b_b5685db10b62_action(self, **kw): - return(200, {}, None) + return (200, {}, None) def post_backups_1234_action(self, **kw): - return(200, {}, None) + return (200, {}, None) def post_backups_5678_action(self, **kw): - return(200, {}, None) + return (200, {}, None) def get_backups_76a17945_3c6f_435c_975b_b5685db10b62_export_record(self, **kw): diff --git a/cinderclient/v3/volumes_base.py b/cinderclient/v3/volumes_base.py index 3b00b59d7..c41361cdf 100644 --- a/cinderclient/v3/volumes_base.py +++ b/cinderclient/v3/volumes_base.py @@ -33,7 +33,7 @@ class Volume(base.Resource): return self.manager.update(self, **kwargs) def attach(self, instance_uuid, mountpoint, mode='rw', host_name=None): - """Inform Cinder that the given volume is attached to the given instance. + """Inform Cinder if the given volume is attached to the given instance. Calling this method will not actually ask Cinder to attach a volume, but to mark it on the DB as attached. If the volume @@ -54,9 +54,10 @@ class Volume(base.Resource): host_name) def detach(self): - """Inform Cinder that the given volume is detached from the given instance. + """Inform Cinder that the given volume is detached. - Calling this method will not actually ask Cinder to detach + This inform Cinder that the given volume is detached from the given + instance. Calling this method will not actually ask Cinder to detach a volume, but to mark it on the DB as detached. If the volume is not actually detached from the given instance, inconsistent data will result. diff --git a/test-requirements.txt b/test-requirements.txt index 0886bd1a8..b7780b39c 100644 --- a/test-requirements.txt +++ b/test-requirements.txt @@ -3,7 +3,7 @@ # process, which may cause wedges in the gate later. # Hacking already pins down pep8, pyflakes and flake8 -hacking>=4.0.0,<4.1.0 # Apache-2.0 +hacking>=7.0.0,<7.1.0 # Apache-2.0 flake8-import-order # LGPLv3 docutils>=0.16 coverage>=5.5 # Apache-2.0