diff --git a/cinderclient/tests/fakes.py b/cinderclient/tests/fakes.py index eede6945d..24ef8b33f 100644 --- a/cinderclient/tests/fakes.py +++ b/cinderclient/tests/fakes.py @@ -22,7 +22,10 @@ places where actual behavior differs from the spec. from __future__ import print_function -def assert_has_keys(dict, required=[], optional=[]): +def assert_has_keys(dict, required=None, optional=None): + required = required or [] + optional = optional or [] + for k in required: try: assert k in dict diff --git a/cinderclient/tests/v1/test_shell.py b/cinderclient/tests/v1/test_shell.py index fb4232863..031c338d8 100644 --- a/cinderclient/tests/v1/test_shell.py +++ b/cinderclient/tests/v1/test_shell.py @@ -81,8 +81,8 @@ class ShellTest(utils.TestCase): # mimic the result of argparse's parse_args() method class Arguments: - def __init__(self, metadata=[]): - self.metadata = metadata + def __init__(self, metadata=None): + self.metadata = metadata or [] inputs = [ ([], {}), diff --git a/cinderclient/utils.py b/cinderclient/utils.py index 367071cd0..25416c646 100644 --- a/cinderclient/utils.py +++ b/cinderclient/utils.py @@ -110,7 +110,8 @@ def _print(pt, order): print(strutils.safe_encode(pt.get_string(sortby=order))) -def print_list(objs, fields, formatters={}, order_by=None): +def print_list(objs, fields, formatters=None, order_by=None): + formatters = formatters or {} mixed_case_fields = ['serverId'] pt = prettytable.PrettyTable([f for f in fields], caching=False) pt.aligns = ['l' for f in fields]