From 6296974b1ad78a5ff56fb5068a38084bcef1f424 Mon Sep 17 00:00:00 2001 From: Joe Gordon Date: Mon, 11 Nov 2013 10:59:20 -0800 Subject: [PATCH] Update link in HACKING.rst and Make it DRYer * Fix URL for global hacking doc, related to I579e7c889f3addc2cd40bce0c584bbc70bf435e2 * Remove section on locals, as its already in openstack-dev/hacking (http://git.openstack.org/cgit/openstack-dev/hacking/tree/doc/source/index.rst#n154) Change-Id: If944b088f343404c5b90b02afe6f781dd1db914d --- HACKING.rst | 11 +---------- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/HACKING.rst b/HACKING.rst index ed887f5f7..59eeb1946 100644 --- a/HACKING.rst +++ b/HACKING.rst @@ -2,7 +2,7 @@ Cinder Client Style Commandments ========================= - Step 1: Read the OpenStack Style Commandments - https://github.com/openstack-dev/hacking/blob/master/HACKING.rst + http://docs.openstack.org/developer/hacking/ - Step 2: Read on Cinder Client Specific Commandments @@ -10,15 +10,6 @@ Cinder Client Specific Commandments General ------- -- Do not use locals(). Example:: - - LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") % - locals()) # BAD - - LOG.debug(_("volume %(vol_name)s: creating size %(vol_size)sG") % - {'vol_name': vol_name, - 'vol_size': vol_size}) # OKAY - - Use 'raise' instead of 'raise e' to preserve original traceback or exception being reraised:: except Exception as e: