From 74ea43450b82c6ca7eeb54b1715f9fec27edd4ef Mon Sep 17 00:00:00 2001 From: haobing1 Date: Thu, 1 Sep 2016 14:34:13 +0800 Subject: [PATCH] Remove self.__dict__ for formatting strings Following OpenStack Style Guidelines: http://docs.openstack.org/developer/hacking/#dictionaries-lists It is not clear as using explicit dictionaries and help avoid some errors during refactoring. Change-Id: If29fa568b757e8e08ec2bd8986d08e422db9eee4 --- tools/lintstack.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/tools/lintstack.py b/tools/lintstack.py index 5639cec69..acde2b0fa 100755 --- a/tools/lintstack.py +++ b/tools/lintstack.py @@ -116,7 +116,12 @@ class LintOutput(object): def review_str(self): return ("File %(filename)s\nLine %(lineno)d:%(line_content)s\n" - "%(code)s: %(message)s" % self.__dict__) # noqa + "%(code)s: %(message)s" % + {'filename': self.filename, + 'lineno': self.lineno, + 'line_content': self.line_content, + 'code': self.code, + 'message': self.message}) class ErrorKeys(object):