From 7a566e69151ba30831a47966450f81ae085c91ff Mon Sep 17 00:00:00 2001 From: Steve Martinelli Date: Mon, 1 Aug 2016 13:01:17 -0400 Subject: [PATCH] deprecate command `cinder endpoints` The command `cinder endpoints` will now print a warning message, indicating that users should use openstackclient instead. This has already been done in nova's CLI [1]. Related-Bug: 1608166 [1] https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L4071-L4072 Change-Id: If68b40cf8116aa0ec386d8067c58703cb7b7c0da --- cinderclient/v1/shell.py | 5 +++++ cinderclient/v3/shell.py | 5 +++++ releasenotes/notes/bug-1608166-ad91a7a9f50e658a.yaml | 7 +++++++ 3 files changed, 17 insertions(+) create mode 100644 releasenotes/notes/bug-1608166-ad91a7a9f50e658a.yaml diff --git a/cinderclient/v1/shell.py b/cinderclient/v1/shell.py index 2c06e6708..3776fa1ec 100644 --- a/cinderclient/v1/shell.py +++ b/cinderclient/v1/shell.py @@ -23,6 +23,7 @@ import copy import os import sys import time +import warnings from cinderclient import exceptions from cinderclient import utils @@ -654,6 +655,10 @@ def do_type_key(cs, args): def do_endpoints(cs, args): """Discovers endpoints registered by authentication service.""" + warnings.warn( + "``cinder endpoints`` is deprecated, use ``openstack catalog list`` " + "instead. The ``cinder endpoints`` command may be removed in the P " + "release or next major release of cinderclient (v2.0.0 or greater).") catalog = cs.client.service_catalog.catalog for e in catalog: utils.print_dict(e['endpoints'][0], e['name']) diff --git a/cinderclient/v3/shell.py b/cinderclient/v3/shell.py index 9ad688114..e051da40c 100644 --- a/cinderclient/v3/shell.py +++ b/cinderclient/v3/shell.py @@ -21,6 +21,7 @@ import copy import os import sys import time +import warnings import six @@ -1034,6 +1035,10 @@ def do_type_access_remove(cs, args): @utils.service_type('volumev3') def do_endpoints(cs, args): """Discovers endpoints registered by authentication service.""" + warnings.warn( + "``cinder endpoints`` is deprecated, use ``openstack catalog list`` " + "instead. The ``cinder endpoints`` command may be removed in the P " + "release or next major release of cinderclient (v2.0.0 or greater).") catalog = cs.client.service_catalog.catalog for e in catalog: utils.print_dict(e['endpoints'][0], e['name']) diff --git a/releasenotes/notes/bug-1608166-ad91a7a9f50e658a.yaml b/releasenotes/notes/bug-1608166-ad91a7a9f50e658a.yaml new file mode 100644 index 000000000..6f92b742b --- /dev/null +++ b/releasenotes/notes/bug-1608166-ad91a7a9f50e658a.yaml @@ -0,0 +1,7 @@ +--- +deprecations: + - | + The ``cinder endpoints`` command has been deprecated. This + command performs an identity operation, and should now be + handled by ``openstack catalog list``. + [Bug `1608166 `_]