From c23586b73f9c8b0e14eb2187ab61c32add0556df Mon Sep 17 00:00:00 2001 From: Lin Yang Date: Mon, 29 Jun 2015 13:49:57 +0800 Subject: [PATCH] Remove redundant statement and refactor 1. Remove redundant pass-statement in except-block. 2. Define "body = None" before if-block to get rid of body-statement both in except-block and else-case. 3. Acknowledge error occurred instead of silently squashing it. Change-Id: I31e17827b40e7a15d88ecacf1fdb2abbbe2da5c0 Signed-off-by: Lin Yang --- cinderclient/client.py | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cinderclient/client.py b/cinderclient/client.py index b68c0605f..2a6b9775f 100644 --- a/cinderclient/client.py +++ b/cinderclient/client.py @@ -238,14 +238,12 @@ class HTTPClient(object): **kwargs) self.http_log_resp(resp) + body = None if resp.text: try: body = json.loads(resp.text) - except ValueError: - pass - body = None - else: - body = None + except ValueError as e: + self._logger.debug("Load http response text error: %s", e) if resp.status_code >= 400: raise exceptions.from_response(resp, body)