From c297309aff29df550633ab956b99bb3d74c7f43c Mon Sep 17 00:00:00 2001 From: LiuNanke Date: Sun, 10 Jan 2016 03:18:08 +0800 Subject: [PATCH] Replace assertTrue(isinstance()) by optimal assert assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests should be replaced by assertIsInstance(A, B) provided by testtools. Related-bug: #1268480 Change-Id: I755702d0f6e982d7cba173fbbdb86feb8ab384a0 --- cinderclient/tests/unit/v2/test_type_access.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cinderclient/tests/unit/v2/test_type_access.py b/cinderclient/tests/unit/v2/test_type_access.py index 7e41b3ee3..d6e8d178f 100644 --- a/cinderclient/tests/unit/v2/test_type_access.py +++ b/cinderclient/tests/unit/v2/test_type_access.py @@ -29,7 +29,7 @@ class TypeAccessTest(utils.TestCase): access = cs.volume_type_access.list(volume_type='3') cs.assert_called('GET', '/types/3/os-volume-type-access') for a in access: - self.assertTrue(isinstance(a, volume_type_access.VolumeTypeAccess)) + self.assertIsInstance(a, volume_type_access.VolumeTypeAccess) def test_add_project_access(self): cs.volume_type_access.add_project_access('3', PROJECT_UUID)