diff --git a/cinderclient/openstack/common/apiclient/base.py b/cinderclient/openstack/common/apiclient/base.py index 460e7b995..abfcdfe7a 100644 --- a/cinderclient/openstack/common/apiclient/base.py +++ b/cinderclient/openstack/common/apiclient/base.py @@ -497,7 +497,7 @@ class Resource(RequestIdMixin): def __getattr__(self, k): if k not in self.__dict__: - #NOTE(bcwaldon): disallow lazy-loading if already loaded once + # NOTE(bcwaldon): disallow lazy-loading if already loaded once if not self.is_loaded(): self.get() return self.__getattr__(k) diff --git a/cinderclient/openstack/common/apiclient/fake_client.py b/cinderclient/openstack/common/apiclient/fake_client.py index 802718652..ed04c18ee 100644 --- a/cinderclient/openstack/common/apiclient/fake_client.py +++ b/cinderclient/openstack/common/apiclient/fake_client.py @@ -81,7 +81,7 @@ class FakeHTTPClient(client.HTTPClient): def __init__(self, *args, **kwargs): self.callstack = [] self.fixtures = kwargs.pop("fixtures", None) or {} - if not args and not "auth_plugin" in kwargs: + if not args and "auth_plugin" not in kwargs: args = (None, ) super(FakeHTTPClient, self).__init__(*args, **kwargs) diff --git a/tools/colorizer.py b/tools/colorizer.py index ebdd236f2..7824b8c78 100755 --- a/tools/colorizer.py +++ b/tools/colorizer.py @@ -110,7 +110,7 @@ class _Win32Colorizer(object): win32console.FOREGROUND_INTENSITY) self.stream = stream self.screenBuffer = win32console.GetStdHandle( - win32console.STD_OUT_HANDLE) + win32console.STD_OUT_HANDLE) self._colors = { 'normal': red | green | blue, 'red': red | bold, @@ -266,7 +266,7 @@ class NovaTestResult(testtools.TestResult): if not self.last_written or (self._now() - time).total_seconds() > 2.0: diff = 3.0 while diff > 2.0: - classes =list(self.results) + classes = list(self.results) oldest = min(classes, key=lambda x: self.last_time[x]) diff = (self._now() - self.last_time[oldest]).total_seconds() self.writeTestCase(oldest) diff --git a/tools/install_venv.py b/tools/install_venv.py index cc2184378..1dab63e89 100644 --- a/tools/install_venv.py +++ b/tools/install_venv.py @@ -22,7 +22,7 @@ import ConfigParser import os import sys -import install_venv_common as install_venv # flake8: noqa +import install_venv_common as install_venv def print_help(project, venv, root): @@ -42,7 +42,7 @@ def print_help(project, venv, root): $ %(root)s/tools/with_venv.sh """ - print help % dict(project=project, venv=venv, root=root) + print (help % dict(project=project, venv=venv, root=root)) def main(argv): diff --git a/tox.ini b/tox.ini index 8b2a1eedf..3794b985d 100644 --- a/tox.ini +++ b/tox.ini @@ -44,4 +44,4 @@ passenv = OS_* [flake8] show-source = True ignore = F811,F821,H306,H404,H405,E122,E123,E128,E251 -exclude=.venv,.git,.tox,dist,doc,*openstack/common*,*lib/python*,*egg,build,tools +exclude=.venv,.git,.tox,dist,doc,*lib/python*,*egg,build