From cb08ce33eb74cb95702081846280a194823d86ae Mon Sep 17 00:00:00 2001 From: Kurt Martin Date: Tue, 3 Nov 2015 15:13:20 -0800 Subject: [PATCH] Fix volume size units to match the API Both Horizon and the cinder client documents the size paramater in gigabyes(GBs) but the API docs(both v1 and v2) list the size units as gibibytes(GiBs). The correct unit should be gibibytes(GiBs). This should help in clearing up any confusion on what units are used in Cinder. Closes-bug: 1511167 Change-Id: I42e15c18d1f084d435a2be9b343fb2f6c3cf377f --- cinderclient/v1/shell.py | 4 ++-- cinderclient/v2/shell.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/cinderclient/v1/shell.py b/cinderclient/v1/shell.py index 3896ac3ab..6049f0322 100644 --- a/cinderclient/v1/shell.py +++ b/cinderclient/v1/shell.py @@ -214,7 +214,7 @@ def do_show(cs, args): @utils.arg('size', metavar='', type=int, - help='Volume size, in GBs.') + help='Volume size, in GiBs.') @utils.arg( '--snapshot-id', metavar='', @@ -1039,7 +1039,7 @@ def do_transfer_show(cs, args): @utils.arg('new_size', metavar='', type=int, - help='Size of volume, in GBs.') + help='Size of volume, in GiBs.') @utils.service_type('volume') def do_extend(cs, args): """Attempts to extend size of an existing volume.""" diff --git a/cinderclient/v2/shell.py b/cinderclient/v2/shell.py index b4447d9ab..9b2ac880e 100644 --- a/cinderclient/v2/shell.py +++ b/cinderclient/v2/shell.py @@ -282,7 +282,7 @@ class CheckSizeArgForCreate(argparse.Action): nargs='?', type=int, action=CheckSizeArgForCreate, - help='Size of volume, in GBs. (Required unless ' + help='Size of volume, in GiBs. (Required unless ' 'snapshot-id/source-volid is specified).') @utils.arg('--consisgroup-id', metavar='', @@ -1520,7 +1520,7 @@ def do_transfer_show(cs, args): @utils.arg('new_size', metavar='', type=int, - help='New size of volume, in GBs.') + help='New size of volume, in GiBs.') @utils.service_type('volumev2') def do_extend(cs, args): """Attempts to extend size of an existing volume."""