openstack/python-cloudkittyclient
Code Issues Proposed changes

Fix creation of hashmap mapping with a zero cost

Browse Source 
A cost of 0.0 was interpreted as a False value, making the check think
the cost argument was missing.

Change-Id: I5f86540221b80667fc63b8b54659092c637b7353
Story: 2009047
Task: 42814
This commit is contained in:
Pierre Riteau
2021-07-12 19:31:06 +02:00
parent b1df2b5ccc
commit 61ef2c337e
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cloudkittyclient/v1/rating/hashmap.py
View File

@@ -172,7 +172,7 @@ class HashmapManager(base.BaseManager):
:param value: Value of the mapping :param value: Value of the mapping
:type value: str :type value: str
""" """
if not kwargs.get('cost'): if kwargs.get('cost') is None:
raise exc.ArgumentRequired("'cost' argument is required") raise exc.ArgumentRequired("'cost' argument is required")
if not kwargs.get('value'): if not kwargs.get('value'):
if not kwargs.get('service_id'): if not kwargs.get('service_id'):

4
releasenotes/notes/fix-zero-cost-mapping-7a4247cf1c6815f8.yaml Normal file
View File

@@ -0,0 +1,4 @@
---
fixes:
- |
Fixes creation of hashmap mappings with a zero cost.