Fix create_threshold
method when using cost as 0
When using 0 as the cost, the `create_threshold` method throws an exception. That happens because 0 (zero) is evaluated to False. Therefore, we need to change the validation method to check if the values are None. Change-Id: Iedd541c0ad16db0d11d6e6de332eddf880af1698
This commit is contained in:
parent
953c6c9443
commit
a15f11a7d2
@ -373,7 +373,7 @@ class HashmapManager(base.BaseManager):
|
|||||||
:type level: str
|
:type level: str
|
||||||
"""
|
"""
|
||||||
for arg in ['cost', 'level']:
|
for arg in ['cost', 'level']:
|
||||||
if not kwargs.get(arg):
|
if kwargs.get(arg) is None:
|
||||||
raise exc.ArgumentRequired(
|
raise exc.ArgumentRequired(
|
||||||
"'{}' argument is required".format(arg))
|
"'{}' argument is required".format(arg))
|
||||||
if not kwargs.get('service_id') and not kwargs.get('field_id'):
|
if not kwargs.get('service_id') and not kwargs.get('field_id'):
|
||||||
|
@ -1,18 +1,18 @@
|
|||||||
# requirements
|
# requirements
|
||||||
pbr==2.0.0 # Apache-2.0
|
pbr==5.5.1 # Apache-2.0
|
||||||
cliff==2.11.0 # Apache-2.0
|
cliff==3.5.0 # Apache-2.0
|
||||||
keystoneauth1==3.4.0 # Apache-2.0
|
keystoneauth1==4.3.0 # Apache-2.0
|
||||||
oslo.utils==3.35 # Apache-2.0
|
oslo.utils==4.7.0 # Apache-2.0
|
||||||
oslo.log==3.36 # Apache-2.0
|
oslo.log==4.4.0 # Apache-2.0
|
||||||
PyYAML==3.12 # MIT
|
PyYAML==5.3.1 # MIT
|
||||||
jsonpath-rw-ext==1.0 # Apache-2.0
|
jsonpath-rw-ext==1.2.0 # Apache-2.0
|
||||||
os-client-config==1.29.0 # Apache-2.0
|
os-client-config==2.1.0 # Apache-2.0
|
||||||
osc-lib==1.12.1 # Apache-2.0
|
osc-lib==2.3.0 # Apache-2.0
|
||||||
|
|
||||||
# test-requirements.txt
|
# test-requirements.txt
|
||||||
pyflakes==2.1.1
|
pyflakes==2.1.1
|
||||||
coverage==4.0 # Apache-2.0
|
coverage==4.0 # Apache-2.0
|
||||||
python-subunit==0.0.18 # Apache-2.0/BSD
|
python-subunit==1.4.0 # Apache-2.0/BSD
|
||||||
oslotest==1.10.0 # Apache-2.0
|
oslotest==1.10.0 # Apache-2.0
|
||||||
stestr==2.0 # Apache-2.0
|
stestr==2.0 # Apache-2.0
|
||||||
mock==2.0 # BSD
|
mock==2.0 # BSD
|
||||||
|
@ -0,0 +1,8 @@
|
|||||||
|
---
|
||||||
|
fixes:
|
||||||
|
- |
|
||||||
|
Fix `create_threshold` method when using cost as 0.
|
||||||
|
When using 0 as the cost, the `create_threshold` method
|
||||||
|
throws an exception. That happens because 0 (zero) is evaluated
|
||||||
|
to False. Therefore, we need to change the validation method to
|
||||||
|
check if the values are None.
|
@ -2,12 +2,12 @@
|
|||||||
# of appearance. Changing the order has an impact on the overall integration
|
# of appearance. Changing the order has an impact on the overall integration
|
||||||
# process, which may cause wedges in the gate later.
|
# process, which may cause wedges in the gate later.
|
||||||
|
|
||||||
pbr>=2.0.0,!=2.1.0 # Apache-2.0
|
pbr>=5.5.1 # Apache-2.0
|
||||||
cliff>=2.11.0 # Apache-2.0
|
cliff>=3.5.0 # Apache-2.0
|
||||||
keystoneauth1>=3.4.0 # Apache-2.0
|
keystoneauth1>=4.3.0 # Apache-2.0
|
||||||
oslo.utils>=3.35 # Apache-2.0
|
oslo.utils>=4.7.0 # Apache-2.0
|
||||||
oslo.log>=3.36 # Apache-2.0
|
oslo.log>=4.4.0 # Apache-2.0
|
||||||
PyYAML>=3.12 # MIT
|
PyYAML>=5.3.1 # MIT
|
||||||
jsonpath-rw-ext>=1.0 # Apache-2.0
|
jsonpath-rw-ext>=1.2.0 # Apache-2.0
|
||||||
os-client-config>=1.29.0 # Apache-2.0
|
os-client-config>=2.1.0 # Apache-2.0
|
||||||
osc-lib>=1.12.1 # Apache-2.0
|
osc-lib>=2.3.0 # Apache-2.0
|
||||||
|
@ -10,7 +10,7 @@ hacking>=3.0.1,<3.1.0 # Apache-2.0
|
|||||||
pyflakes>=2.1.1
|
pyflakes>=2.1.1
|
||||||
|
|
||||||
coverage>=4.0,!=4.4 # Apache-2.0
|
coverage>=4.0,!=4.4 # Apache-2.0
|
||||||
python-subunit>=0.0.18 # Apache-2.0/BSD
|
python-subunit>=1.4.0 # Apache-2.0/BSD
|
||||||
oslotest>=1.10.0 # Apache-2.0
|
oslotest>=1.10.0 # Apache-2.0
|
||||||
stestr>=2.0 # Apache-2.0
|
stestr>=2.0 # Apache-2.0
|
||||||
python-openstackclient>=3.14 # Apache-2.0
|
python-openstackclient>=3.14 # Apache-2.0
|
||||||
|
Loading…
Reference in New Issue
Block a user