openstack
/
python-congressclient
Code Issues Proposed changes

Replace assertEqual(None, *) with assertIsNone in tests 

Replace assertEqual(None, *) with assertIsNone in tests to have
more clear messages in case of failure.

Change-Id: I429c8ab3eb4e79a7556ea6f966dd7aa32ee9b86d
Closes-bug: #1280522
This commit is contained in:
Shuquan Huang 2015-12-17 21:36:58 +08:00
parent f3e9d77cbf
commit 20b4700893
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
congressclient/tests/v1/test_datasource.py
View File

@ -321,7 +321,7 @@ class TestDeleteDatasourceDriver(common.TestCongressBase):
return_value="id"):
result = cmd.take_action(parsed_args)
mocker.assert_called_with("id")
self.assertEqual(None, result)
self.assertIsNone(result)
class TestDatasourceRequestRefresh(common.TestCongressBase):
@ -341,4 +341,4 @@ class TestDatasourceRequestRefresh(common.TestCongressBase):
return_value="id"):
result = cmd.take_action(parsed_args)
mocker.assert_called_with("id", {})
self.assertEqual(None, result)
self.assertIsNone(result)

4
congressclient/tests/v1/test_policy.py
View File

@ -97,7 +97,7 @@ class TestDeletePolicy(common.TestCongressBase):
result = cmd.take_action(parsed_args)
mocker.assert_called_with(policy_id)
self.assertEqual(None, result)
self.assertIsNone(result)
class TestCreatePolicyRule(common.TestCongressBase):
@ -173,7 +173,7 @@ class TestDeletePolicyRule(common.TestCongressBase):
result = cmd.take_action(parsed_args)
mocker.assert_called_with(policy_name, rule_id)
self.assertEqual(None, result)
self.assertIsNone(result)
class TestListPolicyRules(common.TestCongressBase):