openstack
/
python-dracclient
Code Issues Proposed changes

Update patch set 2 

Patch-set: 2
This commit is contained in:
Gerrit User 32205 2020-09-25 11:59:11 +00:00 committed by Gerrit Code Review
parent e38560eca2
commit 36aa005d02
1 changed files with 90 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

90
73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1
View File

@ -23,6 +23,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_551d36bc",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 7,
"author": {
"id": 32205
},
"writtenOn": "2020-09-25T11:59:11Z",
"side": 1,
"message": "Done",
"parentUuid": "9f560f44_37d7f425",
"range": {
"startLine": 7,
"startChar": 36,
"endLine": 7,
"endChar": 49
},
"revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_f7fa9cb7",
@ -46,6 +70,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_351a42c5",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 18,
"author": {
"id": 32205
},
"writtenOn": "2020-09-25T11:59:11Z",
"side": 1,
"message": "Done",
"parentUuid": "9f560f44_f7fa9cb7",
"range": {
"startLine": 17,
"startChar": 0,
"endLine": 18,
"endChar": 11
},
"revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_fddefb67",
@ -63,6 +111,24 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_d5578659",
"filename": "dracclient/client.py",
"patchSetId": 2
},
"lineNbr": 1004,
"author": {
"id": 32205
},
"writtenOn": "2020-09-25T11:59:11Z",
"side": 1,
"message": "Yes, makes more sense to use \"controllers\" instead of units. Corrected",
"parentUuid": "9f560f44_fddefb67",
"revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_d7a15897",
@ -110,6 +176,30 @@
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_156c5e34",
"filename": "dracclient/resources/inventory.py",
"patchSetId": 2
},
"lineNbr": 62,
"author": {
"id": 32205
},
"writtenOn": "2020-09-25T11:59:11Z",
"side": 1,
"message": "Done",
"parentUuid": "9f560f44_3d51930f",
"range": {
"startLine": 62,
"startChar": 62,
"endLine": 62,
"endChar": 74
},
"revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_d77cb821",