Update patch set 2

Patch Set 2: (4 comments) Thanks for the patch, few comments inline. Patch-set: 2 Label: Verified=0
2020-09-08 16:49:47 +00:00 · 2020-09-08 16:49:47 +00:00 · 8e74cac0b5
parent e94af8108e
commit 8e74cac0b5
1 changed files with 96 additions and 0 deletions
--- a/96
+++ b/96
@ -0,0 +1,96 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9f560f44_37d7f425",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 27909
+      },
+      "writtenOn": "2020-09-08T16:49:47Z",
+      "side": 1,
+      "message": "I\u0027d say part \"in dracclient\" is redundant as this is patch in python-dracclient project already.",
+      "range": {
+        "startLine": 7,
+        "startChar": 36,
+        "endLine": 7,
+        "endChar": 49
+      },
+      "revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_f7fa9cb7",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 2
+      },
+      "lineNbr": 18,
+      "author": {
+        "id": 27909
+      },
+      "writtenOn": "2020-09-08T16:49:47Z",
+      "side": 1,
+      "message": "as clarified python-dracclient still lives in https://launchpad.net/python-dracclient\nStory and Task link needs to be removed from this commit message. Optionally can create an issue in launchpad and link it here using the launchpad syntax.\n\nExisting task can be repurposed for ironic patch.",
+      "range": {
+        "startLine": 17,
+        "startChar": 0,
+        "endLine": 18,
+        "endChar": 11
+      },
+      "revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_d7a15897",
+        "filename": "dracclient/resources/inventory.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 62,
+      "author": {
+        "id": 27909
+      },
+      "writtenOn": "2020-09-08T16:49:47Z",
+      "side": 1,
+      "message": "here and for the following why not `pci_device_id`, `pci_vendor_id`, etc.?",
+      "range": {
+        "startLine": 62,
+        "startChar": 62,
+        "endLine": 62,
+        "endChar": 74
+      },
+      "revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_d77cb821",
+        "filename": "dracclient/resources/inventory.py",
+        "patchSetId": 2
+      },
+      "lineNbr": 203,
+      "author": {
+        "id": 27909
+      },
+      "writtenOn": "2020-09-08T16:49:47Z",
+      "side": 1,
+      "message": "I see a code below has similar issue and PEP8 does not mind(?), but I\u0027d decrease the indentation to align with the 1st line of the docstring (see above).",
+      "range": {
+        "startLine": 199,
+        "startChar": 0,
+        "endLine": 203,
+        "endChar": 15
+      },
+      "revId": "73b4df8286a2ff8fffadade4b16ebbdc2c8b53c1",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}