Update patch set 6

Patch Set 6: (8 comments) I have reviewed everything except the unit tests. Please find my comments in-line. Patch-set: 6 Reviewer: Gerrit User 23847 <23847@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
2021-09-16 12:59:44 +00:00 · 2021-09-16 12:59:44 +00:00 · 8fc312dc49
parent 2ff718fa59
commit 8fc312dc49
1 changed files with 178 additions and 0 deletions
--- a/178
+++ b/178
@ -1,5 +1,183 @@
 {
  "comments": [
+    {
+      "key": {
+        "uuid": "79e73f18_20812f6f",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 6
+      },
+      "lineNbr": 7,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "nit: s/from/when/",
+      "range": {
+        "startLine": 7,
+        "startChar": 29,
+        "endLine": 7,
+        "endChar": 33
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "4e9da7f1_d97f4e08",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 6
+      },
+      "lineNbr": 9,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "Let us identify the product the first time as follows:\n\n    Dell EMC PERC H755\n\nSubsequent references can simply be H755.",
+      "range": {
+        "startLine": 9,
+        "startChar": 16,
+        "endLine": 9,
+        "endChar": 20
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "1195af47_c435215b",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 6
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "nit: s/used/later used/",
+      "range": {
+        "startLine": 14,
+        "startChar": 54,
+        "endLine": 14,
+        "endChar": 58
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "ef83e8f9_fd7c3c62",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 6
+      },
+      "lineNbr": 15,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "nit: s/ later//",
+      "range": {
+        "startLine": 15,
+        "startChar": 36,
+        "endLine": 15,
+        "endChar": 42
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "95cf1438_d2bb21ff",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 6
+      },
+      "lineNbr": 16,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "nit: s/from/when/",
+      "range": {
+        "startLine": 16,
+        "startChar": 47,
+        "endLine": 16,
+        "endChar": 51
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "698a8113_e540c3a9",
+        "filename": "dracclient/resources/raid.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 922,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "Please consider applying suggested commit message improvements here.",
+      "range": {
+        "startLine": 914,
+        "startChar": 0,
+        "endLine": 922,
+        "endChar": 0
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "51a7919f_a1c08bd6",
+        "filename": "dracclient/resources/raid.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 959,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "nit: RAID-0",
+      "range": {
+        "startLine": 959,
+        "startChar": 56,
+        "endLine": 959,
+        "endChar": 61
+      },
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
+    {
+      "key": {
+        "uuid": "5ddfd961_b836d0d1",
+        "filename": "dracclient/resources/raid.py",
+        "patchSetId": 6
+      },
+      "lineNbr": 961,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2021-09-16T12:59:44Z",
+      "side": 1,
+      "message": "Please highlight this as the method\u0027s return value by moving it above the comment about the filter on line 959. A brief comment that it is the return value would help.",
+      "revId": "bfc0f8c8b51f022ccfea85d476d5a5acc4f6474a",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": true
+    },
    {
      "key": {
        "uuid": "d708c173_56437831",