Update patch set 3

Patch Set 3: (6 comments) The logic and unit tests look great. I just have a handful of nits. Patch-set: 3
2020-09-25 04:15:20 +00:00 · 2020-09-25 04:15:20 +00:00 · adc985f7eb
parent 1d36cd46cb
commit adc985f7eb
1 changed files with 142 additions and 0 deletions
--- a/142
+++ b/142
@ -0,0 +1,142 @@
+{
+  "comments": [
+    {
+      "key": {
+        "uuid": "9f560f44_8d2cbe93",
+        "filename": "/COMMIT_MSG",
+        "patchSetId": 3
+      },
+      "lineNbr": 14,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2020-09-25T04:15:20Z",
+      "side": 1,
+      "message": "nit: This could simply be one of the following:\n\n    Add video cntlr enumeration to InventoryManagement\n    Add video controller enum to InventoryManagement\n\nThere is no need to get into the details of the implementation or use of it by the ironic idrac driver. The python-dracclient package can be used stand-alone.\n\nThere are other commits which follow the suggested pattern, including https://review.opendev.org/#/c/302407/ and https://review.opendev.org/#/c/340485/.",
+      "range": {
+        "startLine": 7,
+        "startChar": 0,
+        "endLine": 14,
+        "endChar": 12
+      },
+      "revId": "6f28cf29b35ff08873bc68520bc23b9ef32d86cc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_cd4fd667",
+        "filename": "dracclient/client.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1005,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2020-09-25T04:15:20Z",
+      "side": 1,
+      "message": "nit: video controllers",
+      "range": {
+        "startLine": 1005,
+        "startChar": 31,
+        "endLine": 1005,
+        "endChar": 48
+      },
+      "revId": "6f28cf29b35ff08873bc68520bc23b9ef32d86cc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_2d53f217",
+        "filename": "dracclient/client.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 1007,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2020-09-25T04:15:20Z",
+      "side": 1,
+      "message": "Video objects",
+      "range": {
+        "startLine": 1007,
+        "startChar": 28,
+        "endLine": 1007,
+        "endChar": 45
+      },
+      "revId": "6f28cf29b35ff08873bc68520bc23b9ef32d86cc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_0d56ee05",
+        "filename": "dracclient/resources/inventory.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 197,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2020-09-25T04:15:20Z",
+      "side": 1,
+      "message": "Ditto",
+      "range": {
+        "startLine": 197,
+        "startChar": 31,
+        "endLine": 197,
+        "endChar": 48
+      },
+      "revId": "6f28cf29b35ff08873bc68520bc23b9ef32d86cc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_6d696abc",
+        "filename": "dracclient/resources/inventory.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 199,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2020-09-25T04:15:20Z",
+      "side": 1,
+      "message": "Since the name of the namedtuple is Video, consider\n\ns/Video Controller/Video/\n\nOr, perhaps the name of the namedtuple at the top of the file should be changed to VideoController. I am on the fence, because we try to align the naming with those of the DCIM classes. \u0027Video\u0027 seems light.",
+      "range": {
+        "startLine": 199,
+        "startChar": 28,
+        "endLine": 199,
+        "endChar": 44
+      },
+      "revId": "6f28cf29b35ff08873bc68520bc23b9ef32d86cc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    },
+    {
+      "key": {
+        "uuid": "9f560f44_6dae8ae7",
+        "filename": "dracclient/resources/uris.py",
+        "patchSetId": 3
+      },
+      "lineNbr": 48,
+      "author": {
+        "id": 23847
+      },
+      "writtenOn": "2020-09-25T04:15:20Z",
+      "side": 1,
+      "message": "nit: Please move this down in the file, so the alphabetical order of the constant definitions is maintained.",
+      "range": {
+        "startLine": 46,
+        "startChar": 0,
+        "endLine": 48,
+        "endChar": 0
+      },
+      "revId": "6f28cf29b35ff08873bc68520bc23b9ef32d86cc",
+      "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
+      "unresolved": false
+    }
+  ]
+}