openstack
/
python-dracclient
Code Issues Proposed changes

Update patch set 5 

Patch Set 5:

(2 comments)

Patch-set: 5
Attention: {"person_ident":"Gerrit User 27909 \u003c27909@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"Sagar Nanda replied on the change"}
Attention: {"person_ident":"Gerrit User 33121 \u003c33121@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"Sagar Nanda replied on the change"}
This commit is contained in:
Gerrit User 33121 2021-12-15 13:06:44 +00:00 committed by Gerrit Code Review
parent cfdb9d338a
commit b8645a3d78
2 changed files with 39 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
1488d904e2ad19e1b6455f66e23cdb03243f6912 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "59728bb3_317f86a1",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 5
},
"lineNbr": 0,
"author": {
"id": 33121
},
"writtenOn": "2021-12-15T13:06:44Z",
"side": 1,
"message": "Have done the needful.",
"revId": "1488d904e2ad19e1b6455f66e23cdb03243f6912",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

18
b71e16cacc6e16469c57922d6728a4f1466b0d0a
View File

@ -16,6 +16,24 @@
"message": "nit: line deleted unnecessarly",
"revId": "b71e16cacc6e16469c57922d6728a4f1466b0d0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "9368e4cd_a1e79ea2",
"filename": "dracclient/resources/idrac_card.py",
"patchSetId": 4
},
"lineNbr": 50,
"author": {
"id": 33121
},
"writtenOn": "2021-12-15T13:06:44Z",
"side": 0,
"message": "Done",
"parentUuid": "e6a4d9e0_900b9371",
"revId": "b71e16cacc6e16469c57922d6728a4f1466b0d0a",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}