openstack
/
python-dracclient
Code Issues Proposed changes

Update patch set 7 

Patch Set 7:

(3 comments)

thanks for the updates, Yogesh. Some follow up inline.

Patch-set: 7
This commit is contained in:
Gerrit User 27909 2020-09-04 14:43:38 +00:00 committed by Gerrit Code Review
parent 3f7de83def
commit c65f363dd3
1 changed files with 73 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

73
14011b9f4c81b3a9df64241730512e27129c60ed Normal file
View File

@ -0,0 +1,73 @@
{
"comments": [
{
"key": {
"uuid": "9f560f44_8c20a0f9",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 7,
"author": {
"id": 27909
},
"writtenOn": "2020-09-04T14:43:38Z",
"side": 1,
"message": "Given the change in the implementation this does not add a new method anymore, but extends existing. Please update the title and below.",
"range": {
"startLine": 7,
"startChar": 0,
"endLine": 7,
"endChar": 43
},
"revId": "14011b9f4c81b3a9df64241730512e27129c60ed",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_ece83cb4",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 9,
"author": {
"id": 27909
},
"writtenOn": "2020-09-04T14:43:38Z",
"side": 1,
"message": "s/this/This",
"range": {
"startLine": 9,
"startChar": 0,
"endLine": 9,
"endChar": 4
},
"revId": "14011b9f4c81b3a9df64241730512e27129c60ed",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "9f560f44_ac7ac4ec",
"filename": "/COMMIT_MSG",
"patchSetId": 7
},
"lineNbr": 11,
"author": {
"id": 27909
},
"writtenOn": "2020-09-04T14:43:38Z",
"side": 1,
"message": "In unit tests I see something like \u002720200902160859.000000+000\u0027. What\u0027s the format in the end?",
"range": {
"startLine": 11,
"startChar": 3,
"endLine": 11,
"endChar": 17
},
"revId": "14011b9f4c81b3a9df64241730512e27129c60ed",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}