Update patch set 10
Patch Set 10: (3 comments) Yogesh, the code LGTM! I have a few nit picky suggestions to improve the commit message. Also, please consider changing the topic to bug/1894938. You can edit that directly in the Gerrit web UI. See the OpenDev Developer's Guide: https://docs.opendev.org/opendev/infra-manual/latest/developers.html#git-branch-names. Patch-set: 10 Label: Verified=0
This commit is contained in:
parent
b4c0fc9d08
commit
f3ef91e1b8
|
@ -0,0 +1,67 @@
|
|||
{
|
||||
"comments": [
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9f560f44_2ac8f8a5",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 7,
|
||||
"author": {
|
||||
"id": 23847
|
||||
},
|
||||
"writtenOn": "2020-09-25T02:36:47Z",
|
||||
"side": 1,
|
||||
"message": "nit: The headline could be more closely aligned with the description below. For example:\n\n Provide last system inventory time",
|
||||
"revId": "bd61f03d795fe859d5e89a31da76d4dd92c313be",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9f560f44_6a4af026",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 10,
|
||||
"author": {
|
||||
"id": 23847
|
||||
},
|
||||
"writtenOn": "2020-09-25T02:36:47Z",
|
||||
"side": 1,
|
||||
"message": "nit: The iDRAC performs CSIOR, instead of the dracclient.\n\nThis change provides the time system inventory was last performed by the iDRAC. That is done during system restart and referred to as Collect System Inventory on Restart (CSIOR).",
|
||||
"range": {
|
||||
"startLine": 9,
|
||||
"startChar": 0,
|
||||
"endLine": 10,
|
||||
"endChar": 58
|
||||
},
|
||||
"revId": "bd61f03d795fe859d5e89a31da76d4dd92c313be",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
},
|
||||
{
|
||||
"key": {
|
||||
"uuid": "9f560f44_4ac0cc7c",
|
||||
"filename": "/COMMIT_MSG",
|
||||
"patchSetId": 10
|
||||
},
|
||||
"lineNbr": 11,
|
||||
"author": {
|
||||
"id": 23847
|
||||
},
|
||||
"writtenOn": "2020-09-25T02:36:47Z",
|
||||
"side": 1,
|
||||
"message": "nit: in",
|
||||
"range": {
|
||||
"startLine": 11,
|
||||
"startChar": 25,
|
||||
"endLine": 11,
|
||||
"endChar": 27
|
||||
},
|
||||
"revId": "bd61f03d795fe859d5e89a31da76d4dd92c313be",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
|
||||
"unresolved": false
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue