From ce8636b6b3c4b606483cfb2bc405d86224f309bc Mon Sep 17 00:00:00 2001 From: Christian Berendt Date: Tue, 30 Jul 2013 18:26:58 +0200 Subject: [PATCH] removed deprecated parameter --public As noted by bcwaldon the parameter can be removed after updating Devstack. Should be done after merging the following change: https://review.openstack.org/#/c/39323/ Change-Id: I8d0f7ab4cccccf022446374a31e03ac913cfb136 --- glanceclient/v1/shell.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/glanceclient/v1/shell.py b/glanceclient/v1/shell.py index 71882aa4..1210a577 100644 --- a/glanceclient/v1/shell.py +++ b/glanceclient/v1/shell.py @@ -13,7 +13,6 @@ # License for the specific language governing permissions and limitations # under the License. -import argparse import copy import os import sys @@ -193,10 +192,6 @@ def do_image_download(gc, args): help=('Similar to \'--location\' in usage, but this indicates that' ' the Glance server should immediately copy the data and' ' store it in its configured image store.')) -#NOTE(bcwaldon): This will be removed once devstack is updated -# to use --is-public -@utils.arg('--public', action='store_true', default=False, - help=argparse.SUPPRESS) @utils.arg('--is-public', type=utils.string_to_bool, metavar='[True|False]', help='Make image accessible to the public.') @utils.arg('--is-protected', type=utils.string_to_bool, metavar='[True|False]', @@ -211,7 +206,7 @@ def do_image_create(gc, args): # Filter out None values fields = dict(filter(lambda x: x[1] is not None, vars(args).items())) - fields['is_public'] = fields.get('is_public') or fields.pop('public') + fields['is_public'] = fields.get('is_public') if 'is_protected' in fields: fields['protected'] = fields.pop('is_protected')