openstack/python-glanceclient
Code Issues Proposed changes

Adding id for image members

Browse Source
This commit is contained in:
Brian Waldon
2012-04-03 19:26:38 -07:00
parent c72e4dd2b5
commit 538a9e30a2
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
glanceclient/v1/image_members.py
View File

@@ -20,6 +20,10 @@ class ImageMember(base.Resource):
def __repr__(self): def __repr__(self):
return "<ImageMember %s>" % self._info return "<ImageMember %s>" % self._info
@property
def id(self):
return self.member_id
def delete(self): def delete(self):
self.manager.delete(self) self.manager.delete(self)

12
tests/v1/test_image_members.py
View File

@@ -24,13 +24,11 @@ class ImageMemberManagerTest(unittest.TestCase):
self.assertEqual(members[0].can_share, False) self.assertEqual(members[0].can_share, False)
def test_list_by_member(self): def test_list_by_member(self):
members = self.mgr.list(member='1') resource_class = glanceclient.v1.image_members.ImageMember
member = resource_class(self.api, {'member_id': '1'}, True)
self.mgr.list(member=member)
expect = [('GET', '/v1/shared-images/1', {}, None)] expect = [('GET', '/v1/shared-images/1', {}, None)]
self.assertEqual(self.api.calls, expect) self.assertEqual(self.api.calls, expect)
self.assertEqual(len(members), 1)
self.assertEqual(members[0].member_id, '1')
self.assertEqual(members[0].image_id, '1')
self.assertEqual(members[0].can_share, False)
def test_get(self): def test_get(self):
member = self.mgr.get(self.image, '1') member = self.mgr.get(self.image, '1')
@@ -63,9 +61,9 @@ class ImageMemberManagerTest(unittest.TestCase):
def test_replace_objects(self): def test_replace_objects(self):
body = [ body = [
glanceclient.v1.image_members.ImageMember( glanceclient.v1.image_members.ImageMember(
self.mgr, {'member_id': '2', 'can_share': False}), self.mgr, {'member_id': '2', 'can_share': False}, True),
glanceclient.v1.image_members.ImageMember( glanceclient.v1.image_members.ImageMember(
self.mgr, {'member_id': '3', 'can_share': True}), self.mgr, {'member_id': '3', 'can_share': True}, True),
] ]
self.mgr.replace(self.image, body) self.mgr.replace(self.image, body)
expect_body = { expect_body = {