openstack/python-glanceclient
Code Issues Proposed changes

Replace functions 'dict.get' and 'del' with 'dict.pop'

Browse Source 
Refactoring code: Making dict to use single instruction: pop()
rather than two instructions: get() and del, giving the codes a
format that carries through.

TrivialRefactoring

Change-Id: Idb21df37c287fdff24c29153676f82544f735297
This commit is contained in:
bhagyashris
2016-08-26 15:42:57 +05:30
parent c1f54742f9
commit 6740f57096
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
glanceclient/common/http.py
View File

@@ -141,9 +141,8 @@ class HTTPClient(_BaseHTTPClient):
self.auth_token = kwargs.get('token') self.auth_token = kwargs.get('token')
self.language_header = kwargs.get('language_header') self.language_header = kwargs.get('language_header')
if self.identity_headers: if self.identity_headers:
if self.identity_headers.get('X-Auth-Token'): self.auth_token = self.identity_headers.pop('X-Auth-Token',
self.auth_token = self.identity_headers.get('X-Auth-Token') self.auth_token)
del self.identity_headers['X-Auth-Token']
self.session = requests.Session() self.session = requests.Session()
self.session.headers["User-Agent"] = USER_AGENT self.session.headers["User-Agent"] = USER_AGENT