openstack/python-glanceclient
Code Issues Proposed changes

Fix misused assertTrue in unit tests

Browse Source 
Refactored unit tests to use assertEqual instead of assertTrue
where needed.

Closes-Bug: #1226374

Change-Id: I5f3b582e19f3461a04b5df05960095779ec8aa1a
This commit is contained in:
Chang Bo Guo 2013-10-08 19:04:08 -07:00
parent 32d9c42816
commit 7bf27252e5
1 changed files with 3 additions and 1 deletions

4
tests/test_shell.py

@ -87,7 +87,9 @@ class ShellTest(utils.TestCase):
conflict_handler='error', conflict_handler='error',
add_help=False, add_help=False,
formatter_class=openstack_shell.HelpFormatter,) formatter_class=openstack_shell.HelpFormatter,)
self.assertTrue(expected, actual_parser) # NOTE(guochbo): Can't compare ArgumentParser instances directly
# Convert ArgumentPaser to string first.
self.assertEqual(str(expected), str(actual_parser))
def test_get_image_url_by_ipv6Addr_host(self): def test_get_image_url_by_ipv6Addr_host(self):
fake_args = lambda: None fake_args = lambda: None