openstack/python-glanceclient
Code Issues Proposed changes

Output clear error message on invalid api version

Browse Source 
Now if --os-image-api-version mistakenly contains a string then
you will get a ValueError

Example:
$ glance --os-image-api-version hui
ValueError: invalid literal for int() with base 10: 'hui'

This code correctly handles this situation, prints a warning
message and interrupts the execution of the client

Change-Id: I4733578adfc70bd57afd5f0d4d361c8ef689a381
Closes-bug: 1401197
This commit is contained in:
Mike Fedosin
2014-12-10 21:16:23 +03:00
parent 9829d7b6b9
commit 8e8dde2052
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
glanceclient/shell.py
View File

@@ -597,7 +597,11 @@ class OpenStackImagesShell(object):
url_version = None url_version = None
# build available subcommands based on version # build available subcommands based on version
api_version = int(options.os_image_api_version or url_version or 1) try:
api_version = int(options.os_image_api_version or url_version or 1)
except ValueError:
print("Invalid API version parameter")
utils.exit()
if api_version == 2: if api_version == 2:
self._cache_schemas(options) self._cache_schemas(options)