openstack/python-glanceclient
Code Issues Proposed changes

Use immutable arg rather mutable arg

Browse Source 
Passing mutable objects as default args is a known Python pitfall.
We'd better avoid this. This commit changes mutable default args with
None.

Change-Id: I78323383c8b6a9a516a2a217303124870822418b
This commit is contained in:
liuqing
2014-07-01 16:34:16 +08:00
parent 1c46c769e8
commit 9b9f3befed
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
glanceclient/common/utils.py
View File

@@ -45,7 +45,8 @@ def arg(*args, **kwargs):
return _decorator return _decorator
def schema_args(schema_getter, omit=[]): def schema_args(schema_getter, omit=None):
omit = omit or []
typemap = { typemap = {
'string': str, 'string': str,
'integer': int, 'integer': int,
@@ -104,7 +105,8 @@ def pretty_choice_list(l):
return ', '.join("'%s'" % i for i in l) return ', '.join("'%s'" % i for i in l)
def print_list(objs, fields, formatters={}): def print_list(objs, fields, formatters=None):
formatters = formatters or {}
pt = prettytable.PrettyTable([f for f in fields], caching=False) pt = prettytable.PrettyTable([f for f in fields], caching=False)
pt.align = 'l' pt.align = 'l'