openstack/python-glanceclient
Code Issues Proposed changes

Add check Identity validate when get schemas

Browse Source 
Glance client don't check Identity validate when get schemas.
So when you exec "glance image-create" with invalid credentials in
glance-api.conf, it returns "unrecognized arguments: --foo".
It is difficult to debug such message.

This change makes invalid credentials error clear.

Change-Id: Ib641333cd8d51f459df70306a1eeda250ada5ca1
Closes-Bug: 1467719
This commit is contained in:
Takeaki Matsumoto 2015-06-22 19:17:25 +09:00
parent ec0f2dfd85
commit b9eee5ee32
1 changed files with 3 additions and 0 deletions

3
glanceclient/shell.py

@ -577,6 +577,9 @@ class OpenStackImagesShell(object):
with open(schema_file_path, 'w') as f: with open(schema_file_path, 'w') as f:
f.write(json.dumps(schema.raw())) f.write(json.dumps(schema.raw()))
except exc.Unauthorized:
raise exc.CommandError(
"Invalid OpenStack Identity credentials.")
except Exception: except Exception:
# NOTE(esheffield) do nothing here, we'll get a message # NOTE(esheffield) do nothing here, we'll get a message
# later if the schema is missing # later if the schema is missing