openstack
/
python-glanceclient
Code Issues Proposed changes

Don't accept *args for client 

The HTTPClient object that we are passing *args to does not accept any
args. Don't accept them from the main client interface.

Change-Id: I473bb64be95e058375ebd1e55d4bda4168c3c430
This commit is contained in:
Jamie Lennox 2014-12-15 13:39:11 +10:00
parent e386e441af
commit fd2f989cca
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
glanceclient/v1/client.py
View File

@ -29,10 +29,10 @@ class Client(object):
http requests. (optional)
"""
def __init__(self, endpoint, *args, **kwargs):
def __init__(self, endpoint, **kwargs):
"""Initialize a new client for the Images v1 API."""
endpoint, version = utils.strip_version(endpoint)
self.version = version or 1.0
self.http_client = http.HTTPClient(endpoint, *args, **kwargs)
self.http_client = http.HTTPClient(endpoint, **kwargs)
self.images = ImageManager(self.http_client)
self.image_members = ImageMemberManager(self.http_client)

4
glanceclient/v2/client.py
View File

@ -34,10 +34,10 @@ class Client(object):
http requests. (optional)
"""
def __init__(self, endpoint, *args, **kwargs):
def __init__(self, endpoint, **kwargs):
endpoint, version = utils.strip_version(endpoint)
self.version = version or 2.0
self.http_client = http.HTTPClient(endpoint, *args, **kwargs)
self.http_client = http.HTTPClient(endpoint, **kwargs)
self.schemas = schemas.Controller(self.http_client)