Commit Graph

1492 Commits (master)

Author SHA1 Message Date
OpenStack Release Bot 5f2835fcf0 Update master for stable/2023.2
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: I1d1f147333a10f0a526df83ad88b9cff56020cc3
2023-09-15 14:53:18 +00:00
Pranali Deore 62e6fc8270 Release notes for 4.4.0
Change-Id: I96283b493c60de69f4598fb4470fba5fb117d749
2023-07-06 09:31:39 +00:00
Zuul 881f4e6343 Merge "do_image_import: always pass remote_* to gc.images.image_import" 2023-07-04 18:50:19 +00:00
Zuul f53d6714fd Merge "md-property-create: add a mandatory "--type" option" 2023-06-28 16:41:03 +00:00
Zuul ee9f6c6faf Merge "Bump the CHUNKSIZE to use CPU more efficiently" 2023-06-28 16:41:02 +00:00
Cyril Roelandt 7c2ab837aa Docs generation: mock the six module for autodoc
Currently, tox-edocs fails with the following error message:

Warning, treated as error:
autodoc: failed to import module 'shell' from module 'glanceclient'; the
following exception was raised:
No module named 'six'

We used to install six in the virtual environment through keystoneauth,
but keystoneauth no longer depends on six. Let's mock six completely in
the context of autodoc.

Change-Id: Ibcf0b9698227a2c22fe991b7516ba5dceabfc607
2023-06-07 17:26:33 +02:00
Nobuto Murata 7d78cc4b9d Bump the CHUNKSIZE to use CPU more efficiently
The chunk size used for downloading images was 64KiB for some time. That
is okay for relatively small images but the client side of CPU can be a
bottleneck especially for large images. Bump the default chunk size from
64KiB to 1MiB so we can use the client side CPU more efficiently.

[64KiB chunk size - current]
INFO cinder.image.image_utils Image download 1907.35 MB at 68.61 MB/s
-> ~ 549 Mbps

[1MiB chunk size - patched]
INFO cinder.image.image_utils Image download 1907.35 MB at 132.10 MB/s
-> 1,057 Mbps

Closes-Bug: #2020139
Change-Id: I8b6e19621fc989526b02319d88fcfde88a17eee0
2023-05-19 09:40:22 +09:00
Zuul 8681124fcc Merge "do_image_import: fix argument retrieval" 2023-05-16 17:25:30 +00:00
Cyril Roelandt 1ea41f042c do_image_import: always pass remote_* to gc.images.image_import
In do_image_import, gc.images.image_import may be called from two
different places, depending on the command used ("glance image-import"
or "glance image-create-via-import"). Make sure we always pass the
remote_* arguments to gc.images.import.

Change-Id: I76c6ea00523d93bad900776866de6ba22bc516b4
Partial-Bug: #2012442
2023-05-03 15:38:40 +02:00
Zuul 3fdc74b8f2 Merge "Update master for stable/2023.1" 2023-04-27 22:18:58 +00:00
Cyril Roelandt 320ea4b715 Tox4: remove skipsdist
This option causes the installation of the "glance" command to fail in
the functional tests. We have removed it from glance and glance_store in
the past to improve compatibility with tox>=4.0, so let us do the same
in glanceclient.

Change-Id: Ia5bf8d5f90e9cd98adc65c3fa80ce4c87eebad9c
2023-04-18 22:24:37 +02:00
Cyril Roelandt e2190c4feb do_image_import: fix argument retrieval
The argparse module automatically replaces '-' characters with '_'
characters when converting an option string to an attribute:

«For optional argument actions, the value of dest is normally inferred
from the option strings. ArgumentParser generates the value of dest by
taking the first long option string and stripping away the initial --
string. If no long option strings were supplied, dest will be derived
from the first short option string by stripping the initial - character.
Any internal - characters will be converted to _ characters to make sure
the string is a valid attribute name.»[1]

This means that the value of the "--remote-region" option of the
"image-import" command will be available as "args.remote_region";
"remote-region" would not be a valid attribute anyway.

We make sure to retrieve the proper value for the following
options: --remote-region, --remote-image-id and


Change-Id: I1d8c69acd5d61fdc426469cd87d1ace81871e60f
Partial-Bug: #2012442
2023-04-18 03:21:03 +02:00
OpenStack Release Bot 23fe745077 Update master for stable/2023.1
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: I4e1a0a7c870e51909aebdc16d02b0062554de49a
2023-03-01 13:19:13 +00:00
Pranali Deore 52fb6b29d8 Release notes for 4.3.0
Change-Id: I346af48771466c3f9dbaf470f611910ff3dda271
2023-02-16 09:19:07 +00:00
Zuul 2d893b12dd Merge "Unhardcode the value of DEFAULT_PAGE_SIZE from the tests" 2023-02-09 15:33:18 +00:00
Zuul 590f793c9f Merge "Remove unicode-related Python2-only code" 2023-01-12 22:39:42 +00:00
Zuul 9b9c677715 Merge "Boolean options: use strict checking" 2023-01-12 22:39:41 +00:00
Cyril Roelandt 6c95122777 Fix functional tests and docs generation
First, fix test_help(). A commit[1], which first appeared in Python
3.10, changes the output of the help feature of argparse. Options used
to be in a section named "Optional arguments:", and they are now in a
section named "Options:".

Second, tox 4 changes the behaviour of tox, and
{toxinidir}/requirements.txt is no longer installed automagically in the
docs virtual environment. This causes autodoc to fail on some imports.
We explicitely add {toxinidir}/requirements.txt to the list of
dependencies to fix this issue.

These issues should be fixed in separate patches, but since they both
block the CI, they depend on each other.


Change-Id: Ia7866390b31f469bdea95624325a13aaf45a496e
Closes-Bug: #2002566
2023-01-12 14:05:25 +01:00
Zuul 0bd9f80c67 Merge "Replace osc with glance commands" 2022-12-15 14:47:31 +00:00
Cyril Roelandt 88e3b0ad98 Boolean options: use strict checking
Boolean options (such as "--protected" for glance md-namespace-update)
should accept a limited amount of valid values, rather than assuming an
"invalid" value means "False".

The following values (no matter the case) will now be interpreted as
True: ‘t’,’true’, ‘on’, ‘y’, ‘yes’, or ‘1’.

The following values (no matter the case) will now be interpreted as
False: ‘f’, ‘false’, ‘off’, ‘n’, ‘no’, or ‘0’.

Change-Id: I0e7942045d883ac398bab4a7a85f2b4ac9b1ed8c
Closes-Bug: #1607317
2022-11-14 17:31:39 +01:00
Cyril Roelandt 4bb406d377 Unhardcode the value of DEFAULT_PAGE_SIZE from the tests
The value of DEFAULT_PAGE_SIZE (20) was hardcoded in multiple places in
the tests, which means all the tests would break should we ever want to
change that value.

Co-Authored-By:	韩春蕾 <>

Change-Id: I6e8dbae32c3a24d3fbeebcea5bfe0dd9ae247035
2022-11-14 12:04:23 +01:00
Cyril Roelandt fc8f9ac2ed Remove unicode-related Python2-only code
This commit:
- removes the old "u" prefix from all strings
- removes the unicode_key_value_to_string function

Change-Id: I1da347e31e828fd2359f0935a4da47257116d4cb
2022-11-14 11:49:33 +01:00
Zuul f41f2c388b Merge "schema_args: Do not generate option for read-only properties" 2022-11-11 15:55:05 +00:00
Zuul 4e7f83e887 Merge "Make "tox -edocs" generate the manpage" 2022-11-10 15:41:27 +00:00
Cyril Roelandt 74fa436657 schema_args: Do not generate option for read-only properties
The schema_args decorator generates command line options based on the
properties defined in a schema. This commit makes sure read-only
properties are skipped during this process, since trying to modify their
value would result in a Glance error.

Closes-Bug: #1561828
Change-Id: I7ccc628a23c9ebdaeedcb9e6d43559f497ce9555
2022-09-26 23:54:06 +02:00
Erno Kuvaja bbfe6cd3be Replace osc with glance commands
the are glance client docs. OSC should have their own section for this.

Change-Id: I27123793fdf8f8a82afb909f2cceec71693609ea
Closes-Bug: #1990532
2022-09-22 14:02:13 +01:00
OpenStack Release Bot 9e8fcdb92e Switch to 2023.1 Python3 unit tests and generic template name
This is an automatically generated patch to ensure unit testing
is in place for all the of the tested runtimes for antelope. Also,
updating the template name to generic one.

See also the PTI in governance [1].


Change-Id: I0b5f6a1b7de16ea9a5ee50bdc72b0bb4ceef1e29
2022-09-14 09:21:09 +00:00
Cyril Roelandt 393e84d30a md-property-create: add a mandatory "--type" option
The "type" property is required when using md-property-create, so there
should be a mandatory option for it, as is the case for "name" and

Change-Id: I3a118b6f2e375ad60bd4170c5ce0ae284a0c9060
Closes-Bug: #1934626
2022-09-07 18:55:50 +02:00
OpenStack Release Bot a3f13bdcb4 Update master for stable/zed
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: I2c7a8c65882218e927af0ff9771df7276891178e
2022-09-06 13:13:24 +00:00
Zuul f2999ce752 Merge "Add support for glance-download import method" 2022-08-30 14:57:55 +00:00
Pranali Deore 92cd70a224 Add support for glance-download import method
Implements: blueprint glance-download-import-support
Change-Id: Ia2bfad82bccf9acb6103b21112e680c44e295d39
2022-08-30 11:20:40 +00:00
Erno Kuvaja 219568c2a4 Bump default pagesize
Bumping default pagesize to 200. With the previous
default value of 20 glanceclient was doing lots of
extra requests and schema validations.

Based on my tests no performance improvement was
seen over the pagesize of 200.

Change-Id: I6d740ca3a9b32bf5d064d3ea74273bb619b32ad4
Closes-Bug: #1987834
2022-08-26 12:46:20 +01:00
Cyril Roelandt 75218d289e Delete python bytecode before every test run
Because python creates pyc files during tox runs, certain changes in the
tree, like branch switching or file deletion, can create spurious

Closes-Bug: #1368661

Change-Id: I93917b051039506d99837028700bc03337cf68f6
2022-08-02 18:09:50 +02:00
Stephen Finucane 1b854e1657 Remove incorrect note from requirements files
This hasn't been true since pip 20.3 introduced the new dependency
resolver [1]


Change-Id: I394f1135a9f3073ebc17ae9662faf6071e868ca8
Signed-off-by: Stephen Finucane <>
2022-07-12 16:21:38 +01:00
Stephen Finucane 508914c181 Uncap warlock
warlock recently had a 2.0.0 release that added support for jsonschema
4.x [1]. We no longer need to cap this.


Change-Id: Idb4c33284ec36c6c5938bd9045f9729e4ed6f7ea
Signed-off-by: Stephen Finucane <>
2022-07-12 16:21:38 +01:00
Zuul 541593e57e Merge "Check if stdin has isatty attribute" 2022-07-07 16:09:21 +00:00
Zuul 507f16ee16 Merge "Bump tox minversion to 3.18.0" 2022-07-07 16:09:19 +00:00
Benedikt Loeffler 8df9328a60 Check if stdin has isatty attribute
When the stdin is closed, it has no isatty atrribute which leads to a KeyError.

Closes-Bug: #1980890
Change-Id: If9a3bf68b8dfd953b346697241166578d18bb563
2022-07-07 02:55:10 +02:00
Takashi Kajinami be26283a37 Bump tox minversion to 3.18.0
Since tox 3.18.0, the whitelist_externals option has been deprecated in
favor of the new allow_list_externals option[1].

This change bumps the minversion of tox so that we can replace
the deprecated option.


Change-Id: I76f328b8bed1338ab5496d21e54a4b0ff9251147
2022-05-22 22:34:01 +09:00
Ghanshyam Mann be8f394ab1 Update python testing as per zed cycle teting runtime
In Zed cycle, we have dropped the python 3.6/3.7[1] testing
and its support. Moving the py36 job to py38 based as well as
updating the python classifier also to reflect the same.


Change-Id: I9b3a05c708d53d1e7775eefdac802392fd18bc24
2022-05-10 19:11:11 -05:00
Zuul 0b8c28986d Merge "Documentation: Add options for "glance image-import"" 2022-05-05 16:01:00 +00:00
Zuul 68d18dc2f2 Merge "glance help <subcommand>: Clearly specify which options are mandatory" 2022-05-05 16:00:57 +00:00
whoami-rajat cf7504e795 Add doc and test for verbose parameter
We currently have support to show verbose output for image-list
with the command ``glance --verbose image-list`` but there is
no documentation about it.
This patch adds the documentation and a test to run it via CLI.

Closes-Bug: #1969565
Change-Id: Ic6db4f5ab2fecded373b044aa002f9a9bc262513
2022-04-21 14:34:42 +05:30
Zuul 2bb489fe96 Merge "Remove lower-constraints.txt" 2022-03-11 19:57:05 +00:00
Zuul fa7d4bf42a Merge "Update master for stable/yoga" 2022-03-02 18:01:40 +00:00
Brian Rosmaita 6c8108ea33 Fix functional CI job
The glanceclient-dsvm-functional job is currently running unit
tests, whereas it should be running the functional tests.  Fixed
by honoring the path in .stestr.conf like other trees.

Also removed tox.ini from the list of irrelevant-files for this
job, because as it turns out, it is relevant.

Change-Id: I59773caa00ff0dfc970c0e4d45aa5d8ae006b1c6
2022-02-25 13:31:42 -08:00
OpenStack Release Bot b369f75d9a Update master for stable/yoga
Add file to the reno documentation build to show release notes for

Use pbr instruction to increment the minor version number
automatically so that master versions are higher than the versions on

Sem-Ver: feature
Change-Id: Iffb4d1e400b000e4bcedb7e14515a9b9f09b9e05
2022-02-24 14:55:11 +00:00
Zuul 626c50061f Merge "Release notes for 3.6.0" 2022-02-23 15:21:34 +00:00
Abhishek Kekane ac0324c10d Release notes for 3.6.0
Change-Id: I1b441808672c3e362175d20f1d1f282b7f5d70a9
2022-02-22 20:43:20 +00:00
Erno Kuvaja 62f4f67d1d Add support for Cache API
This change provides support for the Cache API changes and
deprecation path for glance-cache-manage command.

Change-Id: I6fca9bbe6bc0bd9b14d8dba685405838131160af
2022-02-22 16:39:33 +00:00