
assertTrue(isinstance(A, B)) or assertEqual(type(A), B) in tests should be replaced by assertIsInstance(A, B) provided by testtools. I have searched all the tests, there is only one wrong usage. Change-Id: Ib1db1a2dca7b5d8cbfe823973e4b571d0f0925c5 Closes-bug: #1268480
30 lines
1.0 KiB
Python
30 lines
1.0 KiB
Python
# Copyright 2012 OpenStack Foundation
|
|
# All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License"); you may
|
|
# not use this file except in compliance with the License. You may obtain
|
|
# a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
|
|
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
|
|
# License for the specific language governing permissions and limitations
|
|
# under the License.
|
|
|
|
import collections
|
|
import testtools
|
|
|
|
from glanceclient import exc
|
|
|
|
|
|
FakeResponse = collections.namedtuple('HTTPResponse', ['status'])
|
|
|
|
|
|
class TestHTTPExceptions(testtools.TestCase):
|
|
def test_from_response(self):
|
|
"""exc.from_response should return instance of an HTTP exception."""
|
|
out = exc.from_response(FakeResponse(400))
|
|
self.assertIsInstance(out, exc.HTTPBadRequest)
|